Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755100AbbGPOyd (ORCPT ); Thu, 16 Jul 2015 10:54:33 -0400 Received: from smtp.citrix.com ([66.165.176.89]:21272 "EHLO SMTP.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751589AbbGPOyc (ORCPT ); Thu, 16 Jul 2015 10:54:32 -0400 X-IronPort-AV: E=Sophos;i="5.15,488,1432598400"; d="scan'208";a="281623421" Message-ID: <55A7C5A1.7060006@citrix.com> Date: Thu, 16 Jul 2015 16:54:25 +0200 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stefano Stabellini CC: , , David Vrabel , , Boris Ostrovsky , Subject: Re: [Xen-devel] [PATCH v2 02/20] xen: Introduce a function to split a Linux page into Xen page References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-3-git-send-email-julien.grall@citrix.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1326 Lines: 49 Hi Stefano, On 16/07/2015 16:23, Stefano Stabellini wrote: >> diff --git a/include/xen/page.h b/include/xen/page.h >> index 8ebd37b..b1f7722 100644 >> --- a/include/xen/page.h >> +++ b/include/xen/page.h >> @@ -39,4 +39,24 @@ struct xen_memory_region xen_extra_mem[XEN_EXTRA_MEM_MAX_REGIONS]; >> >> extern unsigned long xen_released_pages; >> >> +typedef int (*xen_pfn_fn_t)(struct page *page, unsigned long pfn, void *data); >> +/* Break down the page in 4KB granularity and call fn foreach xen pfn */ >> +static inline int xen_apply_to_page(struct page *page, xen_pfn_fn_t fn, >> + void *data) >> +{ >> + unsigned long pfn = xen_page_to_pfn(page); >> + int i; >> + int ret; > > please initialize ret to 0 Hmmm... right. I'm not sure why the compiler didn't catch it. > >> + for (i = 0; i < XEN_PFN_PER_PAGE; i++, pfn++) { >> + ret = fn(page, pfn, data); >> + if (ret) >> + return ret; >> + } >> + >> + return ret; >> +} >> + >> + >> #endif /* _XEN_PAGE_H */ > > > Reviewed-by: Stefano Stabellini Thank you, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/