MIME-Version: 1.0
In-Reply-To: <CALCETrU2Xc_mXwv3pYxKx-bmhY7itfUFYejwWq8QMP-nSqP0Lg@mail.gmail.com>
References: <1437047167-5634-1-git-send-email-brgerst@gmail.com>
	<1437047167-5634-4-git-send-email-brgerst@gmail.com>
	<CALCETrU2Xc_mXwv3pYxKx-bmhY7itfUFYejwWq8QMP-nSqP0Lg@mail.gmail.com>
Date: Thu, 16 Jul 2015 12:02:06 -0400
Message-ID: <CAMzpN2joOga7x+wF7EzOVYq_OLr6JmKm-K8f4koLrTZAQ7pY1A@mail.gmail.com>
Subject: Re: [PATCH 3/7] x86/vm86: Move userspace accesses to do_sys_vm86()
From: Brian Gerst <brgerst@gmail.com>
To: Andy Lutomirski <luto@amacapital.net>
Cc: X86 ML <x86@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Ingo Molnar <mingo@kernel.org>, "H. Peter Anvin" <hpa@zytor.com>,
        Denys Vlasenko <dvlasenk@redhat.com>,
        Linus Torvalds <torvalds@linux-foundation.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1357
Lines: 37

On Thu, Jul 16, 2015 at 11:42 AM, Andy Lutomirski <luto@amacapital.net> wrote:
> On Thu, Jul 16, 2015 at 4:46 AM, Brian Gerst <brgerst@gmail.com> wrote:
>> Move the userspace accesses down into the common function in
>> preparation for the next set of patches.
>
> Nice!
>
> Could you improve the changelog a bit? You're really changing the way
> it works (in a good way).
>
>
>> -       set_flags(regs->pt.flags, VEFLAGS, X86_EFLAGS_VIF | current->thread.v86mask);
>> -       tmp = copy_vm86_regs_to_user(&current->thread.vm86_info->regs, regs);
>> -       tmp += put_user(current->thread.screen_bitmap, &current->thread.vm86_info->screen_bitmap);
>> -       if (tmp) {
>> +       set_flags(regs->pt.flags, VEFLAGS, X86_EFLAGS_VIF | tsk->thread.v86mask);
>> +       user = tsk->thread.vm86_info;
>> +       put_user_try {
>
> I think that put_user_try/put_user_ex requires access_ok.
>
>
>> +       get_user_try {
>> +               unsigned short seg;
>
> This also needs access_ok, I think.

Good catch.  I modeled this off restore_sigcontext(), but the
access_ok() is actually in the caller.

--
Brian Gerst
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/