Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755872AbbGPQMz (ORCPT ); Thu, 16 Jul 2015 12:12:55 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:3449 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754945AbbGPQMy (ORCPT ); Thu, 16 Jul 2015 12:12:54 -0400 X-IronPort-AV: E=Sophos;i="5.15,488,1432598400"; d="scan'208";a="284785089" Message-ID: <55A7D803.4070308@citrix.com> Date: Thu, 16 Jul 2015 17:12:51 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stefano Stabellini CC: , Julien Grall , , David Vrabel , , Boris Ostrovsky , Subject: Re: [Xen-devel] [PATCH v2 04/20] xen/grant: Add helper gnttab_page_grant_foreign_access_ref References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-5-git-send-email-julien.grall@citrix.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 851 Lines: 28 Hi Stefano, On 16/07/2015 16:05, Stefano Stabellini wrote: > I like this. I think it might make sense to call it > gnttab_page_grant_foreign_access_ref_one to make clear that it is only > granting the first 4K. Will do. > In the future we could introduce a new function, called > gnttab_page_grant_foreign_access_ref, that grants all 4K in the page. Unless having a different prototype it won't be possible to do it. This is because one ref = one grant. We would need a list of grant. > In any case > > Reviewed-by: Stefano Stabellini Thank you, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/