Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755511AbbGPQXt (ORCPT ); Thu, 16 Jul 2015 12:23:49 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:13207 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755459AbbGPQXq (ORCPT ); Thu, 16 Jul 2015 12:23:46 -0400 X-IronPort-AV: E=Sophos;i="5.15,488,1432598400"; d="scan'208";a="284789844" Message-ID: <55A7DA8F.2040805@citrix.com> Date: Thu, 16 Jul 2015 17:23:43 +0100 From: Julien Grall User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stefano Stabellini CC: Russell King , , , David Vrabel , , Boris Ostrovsky , Subject: Re: [Xen-devel] [PATCH v2 14/20] xen/grant-table: Make it running on 64KB granularity References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-15-git-send-email-julien.grall@citrix.com> In-Reply-To: Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 838 Lines: 26 Hi Stefano, On 16/07/2015 16:47, Stefano Stabellini wrote: >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c >> index 3679293..0a1f903 100644 >> --- a/drivers/xen/grant-table.c >> +++ b/drivers/xen/grant-table.c > > The arm part is fine, but aren't you missing the change to RPP and SPP? SPP has been removed by commit 548f7c94759ac58d4744ef2663e2a66a106e21c5 as it was unused. For RPP, it's used internally so there is no need to switch to XEN_PAGE_SIZE. Otherwise we will waste 60KB for each internal page allocated (see gnttab_init). Regards, -- Julien Grall -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/