Message-ID: <55A7E334.3030101@caviumnetworks.com>
Date: Thu, 16 Jul 2015 10:00:36 -0700
From: David Daney <ddaney@caviumnetworks.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130625 Thunderbird/17.0.7
MIME-Version: 1.0
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
CC: David Daney <ddaney.cavm@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        Catalin Marinas <Catalin.Marinas@arm.com>,
        Will Deacon <Will.Deacon@arm.com>, Bjorn Helgaas <bhelgaas@google.com>,
        "linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        "Jason Cooper" <jason@lakedaemon.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Robert Richter <rrichter@cavium.com>,
        "David Daney" <david.daney@cavium.com>
Subject: Re: [PATCH 3/5] arm64, pci: Allow RC drivers to supply pcibios_add_device()
 implementation.
References: <1436979285-8177-1-git-send-email-ddaney.cavm@gmail.com> <1436979285-8177-4-git-send-email-ddaney.cavm@gmail.com> <20150716090426.GA17097@red-moon>
In-Reply-To: <20150716090426.GA17097@red-moon>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
BY1PR0701MB1722: X-MS-Exchange-Organization-RulesExecuted
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Jul 2015 17:00:41.7395 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY1PR0701MB1722
X-Microsoft-Exchange-Diagnostics: 1;BY1PR0701MB1708;2:wvpU3A+0EKrxr87g+hloDuae8JXUhS980X7klkDnCbnCFnzZvQ6KaunBdjJrWUMr;3:qTo0iIePPoDZ8R54kftMSTdY/S/mgvREt2La1ciVwFC8nkWG+bPIYAgW6Kpc17fbtgB1GXmt9qVv2tttXOugG10rYvNv7tgi9zFJy2tKf8CIfBuC7We6CZMdQVxceuzN47cN2t9F33hoY5G9731vXw==;25:lPJEm+Gf7YHR/J0Zk99qUDsvD+/5e+BZl5gYpwW6ORU6+OpGlhco7Y+Nz8FFRPHKWlmvGlSv3VM0M8B9jDbedp5EIssFb15QnYM9+GK//l0NpZ9j6to2VKcsZMALaaMHmPx0nLYMpWPmvHk13Q4QJSwZ5515hJJCMRvPgzZLPm06e20vhYS2vqJbF9kz/n1gQwezGSeoneOSAMk0meJcldivIGmm0EKV7eQS7KCX67U92XXFLcW1aPZQYUukoPKugU8hXAYYjm5WTpSnE219TA==;20:64KF88Rn/IhXqdr+dfYWTf0rQv0Oft2dKPObpgQgRqEbWIQ4R5NDLUWF+pLESlnjHBxrBpyrIiZIhDqlMV6Aww==;23:bcCJzdgo2glipyHGC34zf27awWQaEQmTtRWUImtbJSWNzKTTUhnrDvgwDMNjuYnwg+ITKnQfYBN7LrNrCCT6zGNbXj+FKtE3I0LuugulpE1QX1qdJYyuwRBuqDcJec1rlkc4yL8ECy/eR4leMIaU3+sd7zXbsCB1qkiMlWOMnonDx3GPTkx4yavAMieqHpGSf/yOpQf2pCOBqSyA+fWvRRJ45zqgo6frIQd3JH0YTeHD52s982wSRt7i+5Qhkd9u
BY1PR0701MB1708: X-MS-Exchange-Organization-RulesExecuted
X-OriginatorOrg: caviumnetworks.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1581
Lines: 58

On 07/16/2015 02:04 AM, Lorenzo Pieralisi wrote:
> Hi David,
>
> On Wed, Jul 15, 2015 at 05:54:43PM +0100, David Daney wrote:
>> From: David Daney <david.daney@cavium.com>
>>
[...]
>> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c
>> index 4095379..3356023 100644
>> --- a/arch/arm64/kernel/pci.c
>> +++ b/arch/arm64/kernel/pci.c
>> @@ -38,11 +38,21 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res,
>>   	return res->start;
>>   }
>>
>> +static int (*pcibios_add_device_impl)(struct pci_dev *);
>> +
>> +void set_pcibios_add_device(int (*arg)(struct pci_dev *))
>> +{
>> +	pcibios_add_device_impl = arg;
>> +}
>> +
>>   /*
>>    * Try to assign the IRQ number from DT when adding a new device
>>    */
>>   int pcibios_add_device(struct pci_dev *dev)
>>   {
>> +	if (pcibios_add_device_impl)
>> +		return pcibios_add_device_impl(dev);
>
> I am totally against this (and to be honest by reading the other
> patches I failed to understand why you even need it), see above.
>

It is because ...


> Thanks,
> Lorenzo
>
>> +
>>   	dev->irq = of_irq_parse_and_map_pci(dev, 0, 0);


  ... this is total crap.  But I didn't want to break existing systems.

The PCI RC drivers need a way to configure the legacy virtual-wire 
interrupts, because the existing code doesn't do it.

David Daney


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/