Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755488AbbGPRRj (ORCPT ); Thu, 16 Jul 2015 13:17:39 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:47508 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbbGPRRh (ORCPT ); Thu, 16 Jul 2015 13:17:37 -0400 X-IronPort-AV: E=Sophos;i="5.15,488,1432598400"; d="scan'208";a="284812475" Date: Thu, 16 Jul 2015 18:16:32 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Stefano Stabellini CC: Julien Grall , , , , , Konrad Rzeszutek Wilk , Boris Ostrovsky , "David Vrabel" Subject: Re: [PATCH v2 19/20] xen/privcmd: Add support for Linux 64KB page granularity In-Reply-To: Message-ID: References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-20-git-send-email-julien.grall@citrix.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1009 Lines: 22 On Thu, 16 Jul 2015, Stefano Stabellini wrote: > > + /* setup_hparams guarantees ret == 0 */ > > + BUG_ON(xen_apply_to_page(page, setup_hparams, info)); > > + > > + set_xen_guest_handle(xatp.idxs, info->h_idxs); > > + set_xen_guest_handle(xatp.gpfns, info->h_gpfns); > > + set_xen_guest_handle(xatp.errs, info->h_errs); > > + xatp.size = info->h_iter; > > + > > + rc = HYPERVISOR_memory_op(XENMEM_add_to_physmap_range, &xatp); > > I would have thought that XENMEM_add_to_physmap_range operates at 4K > granularity, regardless of how the guest decides to layout its > pagetables. If so, the call to XENMEM_add_to_physmap_range needs to be > moved within the function passed to xen_apply_to_page. Sorry, this comment is wrong, please ignore it. The others are OK. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/