Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964825AbbGPRhJ (ORCPT ); Thu, 16 Jul 2015 13:37:09 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:35311 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964790AbbGPRhG (ORCPT ); Thu, 16 Jul 2015 13:37:06 -0400 Date: Thu, 16 Jul 2015 19:36:58 +0200 From: Rabin Vincent To: Krzysztof Kozlowski Cc: Linus Walleij , Alexandre Courbot , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check Message-ID: <20150716173658.GA1824@debian> References: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 756 Lines: 18 On Thu, Jul 09, 2015 at 10:19:53PM +0900, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski > Fixes: d342571efea8 ("gpio: add ETRAXFS GPIO driver") Acked-by: Rabin Vincent > Cc: I don't think this demands a stable backport though. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/