Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756275AbbGPRye (ORCPT ); Thu, 16 Jul 2015 13:54:34 -0400 Received: from e28smtp02.in.ibm.com ([122.248.162.2]:36741 "EHLO e28smtp02.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751788AbbGPRyc (ORCPT ); Thu, 16 Jul 2015 13:54:32 -0400 X-Helo: d28dlp01.in.ibm.com X-MailFrom: honclo@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Subject: Re: [PATCH v4 1/2] vTPM: support little endian guests From: "Hon Ching(Vicky) Lo" To: Peter =?ISO-8859-1?Q?H=FCwe?= Cc: tpmdd-devel@lists.sourceforge.net, Ashley Lai , Vicky Lo , linux-kernel@vger.kernel.org, Joy Latten In-Reply-To: <201507132308.00824.PeterHuewe@gmx.de> References: <1434579429-29449-1-git-send-email-honclo@linux.vnet.ibm.com> <201507132308.00824.PeterHuewe@gmx.de> Content-Type: text/plain; charset="UTF-8" Date: Thu, 16 Jul 2015 13:54:15 -0400 Message-ID: <1437069255.29298.5.camel@vtpm2014.ibm.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.3 (2.32.3-34.el6) Content-Transfer-Encoding: 8bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15071617-0005-0000-0000-00000674D8BD Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1466 Lines: 51 Hi Peter, On Mon, 2015-07-13 at 23:08 +0200, Peter Hüwe wrote: > Hi Vicky, > > sorry for the late reply > > > > This patch makes the code endianness independent. We defined a > > macro do_endian_conversion to apply endianness to raw integers > > in the event entries so that they will be displayed properly. > > tpm_binary_bios_measurements_show() is modified for the display. > > > > Signed-off-by: Hon Ching(Vicky) Lo > > Signed-off-by: Joy Latten > > > b/drivers/char/tpm/tpm_eventlog.h index e7da086..267bfbd 100644 > > --- a/drivers/char/tpm/tpm_eventlog.h > > +++ b/drivers/char/tpm/tpm_eventlog.h > > @@ -6,6 +6,12 @@ > > #define MAX_TEXT_EVENT 1000 /* Max event string length */ > > #define ACPI_TCPA_SIG "TCPA" /* 0x41504354 /'TCPA' */ > > > > +#ifdef CONFIG_PPC64 > > +#define do_endian_conversion(x) be32_to_cpu(x) > > +#else > > +#define do_endian_conversion(x) x > > +#endif > > > Why is this macro needed? > shouldn't the be32_to_cpu macro already do correct thing? > Or am I missing something here? > > > Thanks, > Peter > The macro is defined to not do the conversion in the architecture that does not need it. Regards, Vicky -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/