Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756308AbbGPSD7 (ORCPT ); Thu, 16 Jul 2015 14:03:59 -0400 Received: from casper.infradead.org ([85.118.1.10]:44699 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752322AbbGPSD6 (ORCPT ); Thu, 16 Jul 2015 14:03:58 -0400 Date: Thu, 16 Jul 2015 20:03:48 +0200 From: Peter Zijlstra To: Tom Zanussi Cc: rostedt@goodmis.org, daniel.wagner@bmw-carit.de, masami.hiramatsu.pt@hitachi.com, namhyung@kernel.org, josh@joshtriplett.org, andi@firstfloor.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v9 07/22] tracing: Add lock-free tracing_map Message-ID: <20150716180348.GI12596@twins.programming.kicks-ass.net> References: <777bd36975a1dd904fd6b72c4048474dd2327a65.1437066836.git.tom.zanussi@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <777bd36975a1dd904fd6b72c4048474dd2327a65.1437066836.git.tom.zanussi@linux.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 562 Lines: 13 On Thu, Jul 16, 2015 at 12:22:40PM -0500, Tom Zanussi wrote: > + map->map = kcalloc(map->map_size, sizeof(struct tracing_map_entry), > + GFP_KERNEL); In a later email you state the max map size to be 128k, with a 16 byte struct, that is 2m of memory for this allocation. Isn't that a tad big for a kmalloc() ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/