Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755217AbbGPSkj (ORCPT ); Thu, 16 Jul 2015 14:40:39 -0400 Received: from smtp.opengridcomputing.com ([72.48.136.20]:40069 "EHLO smtp.opengridcomputing.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbbGPSki (ORCPT ); Thu, 16 Jul 2015 14:40:38 -0400 From: "Steve Wise" To: "'Nicholas Krause'" , Cc: , , , , References: <1437071644-23895-1-git-send-email-xerofoify@gmail.com> In-Reply-To: <1437071644-23895-1-git-send-email-xerofoify@gmail.com> Subject: RE: [PATCH] infiniband:cxgb4:Make the function rdma_supported bool Date: Thu, 16 Jul 2015 13:40:41 -0500 Message-ID: <003901d0bff6$eb0aadb0$c1200910$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQIRlDq9ukXZUtfhBRNMXrj/PiuCUp1cxTSw Content-Language: en-us Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1576 Lines: 40 Is this change really worth the effort? > -----Original Message----- > From: Nicholas Krause [mailto:xerofoify@gmail.com] > Sent: Thursday, July 16, 2015 1:34 PM > To: swise@chelsio.com > Cc: dledford@redhat.com; sean.hefty@intel.com; hal.rosenstock@gmail.com; linux-rdma@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] infiniband:cxgb4:Make the function rdma_supported bool > > This makes the function rdma_supported have a return type of bool > due to this particular function's return statement always returning > either one or zero as its return value. > > Signed-off-by: Nicholas Krause > --- > drivers/infiniband/hw/cxgb4/device.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/infiniband/hw/cxgb4/device.c b/drivers/infiniband/hw/cxgb4/device.c > index 1a29739..285f6606 100644 > --- a/drivers/infiniband/hw/cxgb4/device.c > +++ b/drivers/infiniband/hw/cxgb4/device.c > @@ -912,7 +912,7 @@ static void c4iw_remove(struct uld_ctx *ctx) > c4iw_dealloc(ctx); > } > > -static int rdma_supported(const struct cxgb4_lld_info *infop) > +static bool rdma_supported(const struct cxgb4_lld_info *infop) > { > return infop->vr->stag.size > 0 && infop->vr->pbl.size > 0 && > infop->vr->rq.size > 0 && infop->vr->qp.size > 0 && > -- > 2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/