Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756029AbbGPUcs (ORCPT ); Thu, 16 Jul 2015 16:32:48 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:54401 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751222AbbGPUcq (ORCPT ); Thu, 16 Jul 2015 16:32:46 -0400 Date: Thu, 16 Jul 2015 21:32:32 +0100 From: Mark Brown To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, lgirdwood@gmail.com, sameo@linux.intel.com, lee.jones@linaro.org, linux-kernel@vger.kernel.org Message-ID: <20150716203232.GA1602@sirena.org.uk> References: <1437070618-21330-1-git-send-email-vaibhav.hiremath@linaro.org> <1437070618-21330-6-git-send-email-vaibhav.hiremath@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <1437070618-21330-6-git-send-email-vaibhav.hiremath@linaro.org> X-Cookie: Absence makes the heart forget. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 5/5] regulator: 88pm800: Add support for configuration of dual phase on BUCK1 X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1548 Lines: 40 --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 16, 2015 at 11:46:58PM +0530, Vaibhav Hiremath wrote: > .disable = regulator_disable_regmap, > .is_enabled = regulator_is_enabled_regmap, > .get_current_limit = pm800_get_current_limit, > + .set_current_limit = pm800_set_current_limit, set_current_limit() isn't the right interface to use for this, this is something that depends on the physical design of the system rather than something that limits the current. It should be a DT property of its own. There are some other PMICs with similar functions but it's not clear yet how generic the configuration mechanism is. --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVqBTWAAoJECTWi3JdVIfQBbQH/AoaAP15jHjKfJpPZltLYcF7 Bw6A0EExIhMNLbVgjQ+wnVpCu7kIqWY9Pz/OIy+AXOHrknQ4Y2XZdeEKG0/IZE7F +IykZ+i94MA1O1vSc6rMqedjlqQAWekLrQDNgSJmXEmk/Z7HmsC3SzsSr03NPsZc o7bRfiF509ObNKQ2d0C+J+DUcTyC4UGth7w85PS+InPei5nwLTUgqHGdWC+xARdM eRsg++9qmPN2aj0vQec/m+DTLmaCo5LU1AeXBPtfMpC+T4rtboMa8nveP7HBP+cm OKf6L73MYWphP83gage5DTgkM2eNi5hnNcgwaPHDAu9JEWokQRLK0TuTTSGG2Dg= =RnQW -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/