Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756417AbbGPWkh (ORCPT ); Thu, 16 Jul 2015 18:40:37 -0400 Received: from v094114.home.net.pl ([79.96.170.134]:63945 "HELO v094114.home.net.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751490AbbGPWkg (ORCPT ); Thu, 16 Jul 2015 18:40:36 -0400 From: "Rafael J. Wysocki" To: "Jon Medhurst (Tixy)" Cc: Viresh Kumar , linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org, open list Subject: Re: [PATCH 2/2] cpufreq: Properly handle errors from cpufreq_init_policy() Date: Fri, 17 Jul 2015 01:07:15 +0200 Message-ID: <3304290.JRKWihrc9M@vostro.rjw.lan> User-Agent: KMail/4.11.5 (Linux/4.1.0-rc5+; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1437038174.2842.6.camel@linaro.org> References: <276debea91831d86c34079f6a40d773ce258a62c.1436348436.git.viresh.kumar@linaro.org> <3547840.51rbRs871Y@vostro.rjw.lan> <1437038174.2842.6.camel@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1749 Lines: 46 On Thursday, July 16, 2015 10:16:14 AM Jon Medhurst wrote: > On Thu, 2015-07-16 at 02:32 +0200, Rafael J. Wysocki wrote: > > On Wednesday, July 08, 2015 04:50:23 PM Viresh Kumar wrote: > > > On 08-07-15, 12:17, Jon Medhurst (Tixy) wrote: > > > > I tried these patches without the earlier "cpufreq: Initialize the > > > > governor again while restoring policy" patch. > > > > > > > > The result is that the error when bringing a cpu online is with flagged > > > > up with a kernel message: > > > > > > > > cpufreq: cpufreq_add_dev: Failed to initialize policy for cpu: 1 (-16) > > > > > > > > and afterwards, the sysfs entries that I was poking and causing the > > > > crash aren't present. So looks like this patch has done what we want, > > > > and cleaned things up after an error. So... > > > > > > > > Tested-by: Jon Medhurst > > > > > > > > Thanks for the prompt fix. > > > > > > And thanks for your help in getting these tested :) > > > > Both queued up for 4.3, thanks! > > The crash I was getting was a regression caused by changes that went > into 4.2-rc1. > > Indeed, the first patch from Viresh is marked: > > Fixes: 18bf3a124ef8 ("cpufreq: Mark policy->governor = NULL for inactive policies") > For 4.2-rc > > And I am having to carry that first patch to keep two ARM big.LITTLE > platforms working. That one is going into 4.2-rc, I'm about to send a pull request with it. -- I speak only for myself. Rafael J. Wysocki, Intel Open Source Technology Center. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/