Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756232AbbGPXWw (ORCPT ); Thu, 16 Jul 2015 19:22:52 -0400 Received: from ozlabs.org ([103.22.144.67]:56978 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751490AbbGPXWv (ORCPT ); Thu, 16 Jul 2015 19:22:51 -0400 Date: Fri, 17 Jul 2015 09:22:49 +1000 From: Stephen Rothwell To: Oleg Nesterov Cc: Andrew Morton , Joonsoo Kim , Benjamin LaHaise , Fengguang Wu , Jeff Moyer , Johannes Weiner , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix Message-ID: <20150717092249.76adc131@canb.auug.org.au> In-Reply-To: <20150716231405.GA25147@redhat.com> References: <20150716231405.GA25147@redhat.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; i586-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 26 Hi Oleg, On Fri, 17 Jul 2015 01:14:05 +0200 Oleg Nesterov wrote: > > fs/aio.c can't be compiled if CONFIG_MMU=n, filemap_page_mkwrite() > is not defined in this case. Add yet another "must not be called" > helper into nommu.c to make the linker happy. > > I still think this is pointless, afaics sys_io_setup() simply can't > succeed if CONFIG_MMU=n. Instead we should make CONFIG_AIO depend > on CONFIG_MMU. > > Reported-by: Fengguang Wu > Reported-by: Stephen Rothwell > Signed-off-by: Oleg Nesterov Added as a fix to linux-next today. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/