Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756755AbbGPX1w (ORCPT ); Thu, 16 Jul 2015 19:27:52 -0400 Received: from mail-pa0-f51.google.com ([209.85.220.51]:33677 "EHLO mail-pa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755380AbbGPX1u (ORCPT ); Thu, 16 Jul 2015 19:27:50 -0400 Message-ID: <55A83D86.2030505@gmail.com> Date: Thu, 16 Jul 2015 16:25:58 -0700 From: Florian Fainelli User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Stas Sergeev , netdev CC: Linux kernel , Sebastien Rannou , Arnaud Ebalard , Stas Sergeev Subject: Re: [PATCH 1/3] fixed_phy: handle link-down case References: <55A7C45F.1070501@list.ru> <55A7C49E.2020803@list.ru> In-Reply-To: <55A7C49E.2020803@list.ru> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1858 Lines: 64 On 16/07/15 07:50, Stas Sergeev wrote: > > Currently fixed_phy driver recognizes only the link-up state. > This simple patch adds an implementation of link-down state. > It fixes the status registers when link is down, and also allows > to register the fixed-phy with link down without specifying the speed. This patch still breaks my setups here, e.g: drivers/net/dsa/bcm_sf2.c, but I will look into it. Do we really need this for now for your two other patches to work properly, or is it just nicer to have? > > Signed-off-by: Stas Sergeev > > CC: Florian Fainelli > CC: netdev@vger.kernel.org > CC: linux-kernel@vger.kernel.org > --- > drivers/net/phy/fixed_phy.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/phy/fixed_phy.c b/drivers/net/phy/fixed_phy.c > index 1960b46..479b93f 100644 > --- a/drivers/net/phy/fixed_phy.c > +++ b/drivers/net/phy/fixed_phy.c > @@ -52,6 +52,10 @@ static int fixed_phy_update_regs(struct fixed_phy *fp) > u16 lpagb = 0; > u16 lpa = 0; > > + if (!fp->status.link) > + goto done; > + bmsr |= BMSR_LSTATUS | BMSR_ANEGCOMPLETE; > + > if (fp->status.duplex) { > bmcr |= BMCR_FULLDPLX; > > @@ -96,15 +100,13 @@ static int fixed_phy_update_regs(struct fixed_phy *fp) > } > } > > - if (fp->status.link) > - bmsr |= BMSR_LSTATUS | BMSR_ANEGCOMPLETE; > - > if (fp->status.pause) > lpa |= LPA_PAUSE_CAP; > > if (fp->status.asym_pause) > lpa |= LPA_PAUSE_ASYM; > > +done: > fp->regs[MII_PHYSID1] = 0; > fp->regs[MII_PHYSID2] = 0; > -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/