Date: Fri, 17 Jul 2015 08:30:22 +0800
From: Peter Chen <peter.chen@freescale.com>
To: Roger Quadros <rogerq@ti.com>
CC: <stern@rowland.harvard.edu>, <balbi@ti.com>, <gregkh@linuxfoundation.org>,
        <dan.j.williams@intel.com>, <jun.li@freescale.com>,
        <mathias.nyman@linux.intel.com>, <tony@atomide.com>,
        <Joao.Pinto@synopsys.com>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3 05/11] usb: hcd.h: Add OTG to HCD interface
Message-ID: <20150717003021.GB3609@shlinux2>
References: <1436350777-28056-1-git-send-email-rogerq@ti.com>
 <1436350777-28056-6-git-send-email-rogerq@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1436350777-28056-6-git-send-email-rogerq@ti.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2015 01:39:39.4957
 (UTC)
X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0301MB1232
X-Microsoft-Exchange-Diagnostics: 1;DM2PR0301MB0685;2:0B+s2lAkx42BYk8BEZzeyOF2cImaxV9D/b8L4kDwVju6Jzh1712EOYZOC+Mb85if;3:a5SiIVXABbyq+VV1w17QTBhw7BMGix5vUJ8iLLOkdEJJ9UtmkvCQkcLQnqatxC93Ze8zyXg0HtBXsou8OxNlVGOIq4rISjFud6ozs4QSMU95QqRM7ZHZzBSgygUgoh3j4bYYl5XrDvBxh61AEL39a5VsOCwx51fEcsB8Ict0CzWVHyq1pM4isNSR6LTs+POl6Y12eQ1c4EadFraL9Uuh16s8UrGK+NtcYzJBN0DpfXU=;25:2VVg0o/+t29mrBiPWSnNFz7VtAIOSjxF/Lqt1aFzH/BUsUXRKCX5HzPA1zRuxZWxXxs18D3rUThDN6v2PTt8OzADVsvtc87rIW7BpSxZoGqm2JY5uTl3jJO93oP5OdBklmaspaxjfKxiLGjcrv6ovn/Qv1lop5H5j4XDoOAcZn1NQBwrhR96Pf/VZ3qG0Vqla8mJOaap2de0euv06NcXdZr1hovoTgtDvTgkLiXwrFBmzY9xua854xbiTiTTDJzym1G8HX7ZFqZiSQSItnJWfA==;23:evsA1iZT/QPR/VNVh2aoPZyudulOIEYL2GNUZPmITcAC/jf8Sz29Qz6Noe+dRw741a6JAa7HRvgIJeiVqN4diDqzShlxbMRIcynei60Jy/hlCsg0C1Y6Uzok7Wr4PDgFb2qkoxYCFD6FXZoh2NpBkZpUu9XVWc+UEZp/zAS+D00rB5p9JzqxLjHlqM2W6gISfYXSSdh6u9AgVC9O5Cs4uNcWEfVTLdeJZ6yyRO8zIAhYC4GEkRukvXFtnAbUCD4x
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1553
Lines: 54

On Wed, Jul 08, 2015 at 01:19:31PM +0300, Roger Quadros wrote:
> The OTG core will use struct otg_hcd_ops to
> add/remove the HCD controller.
> 
> The main purpose of this interface is to avoid directly
> calling usb_add/remove_hcd() from the OTG core as they
> wouldn't be defined in the built-in symbol table if
> CONFIG_USB is m.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  include/linux/usb/hcd.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/include/linux/usb/hcd.h b/include/linux/usb/hcd.h
> index c9aa779..4108288 100644
> --- a/include/linux/usb/hcd.h
> +++ b/include/linux/usb/hcd.h
> @@ -386,6 +386,20 @@ struct hc_driver {
>  
>  };
>  
> +/**
> + * struct otg_hcd_ops - Interface between OTG core and HCD
> + *
> + * Provided by the HCD core to allow the OTG core to start/stop the HCD
> + *
> + * @add: function to add the HCD
> + * @remove: function to remove the HCD
> + */
> +struct otg_hcd_ops {
> +	int (*add)(struct usb_hcd *hcd,
> +		   unsigned int irqnum, unsigned long irqflags);
> +	void (*remove)(struct usb_hcd *hcd);
> +};
> +
>  static inline int hcd_giveback_urb_in_bh(struct usb_hcd *hcd)
>  {
>  	return hcd->driver->flags & HCD_BH;
> -- 
> 2.1.4
> 

Reviewed-by: Peter Chen <peter.chen@freescale.com>

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/