Date: Fri, 17 Jul 2015 08:31:27 +0800
From: Peter Chen <peter.chen@freescale.com>
To: Roger Quadros <rogerq@ti.com>
CC: <stern@rowland.harvard.edu>, <balbi@ti.com>, <gregkh@linuxfoundation.org>,
        <dan.j.williams@intel.com>, <jun.li@freescale.com>,
        <mathias.nyman@linux.intel.com>, <tony@atomide.com>,
        <Joao.Pinto@synopsys.com>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-omap@vger.kernel.org>
Subject: Re: [PATCH v3 06/11] usb: gadget.h: Add OTG to gadget interface
Message-ID: <20150717003126.GC3609@shlinux2>
References: <1436350777-28056-1-git-send-email-rogerq@ti.com>
 <1436350777-28056-7-git-send-email-rogerq@ti.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <1436350777-28056-7-git-send-email-rogerq@ti.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
BN3PR0301MB1219: X-MS-Exchange-Organization-RulesExecuted
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2015 01:40:43.8714
 (UTC)
X-MS-Exchange-CrossTenant-Id: 710a03f5-10f6-4d38-9ff4-a80b81da590d
X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=710a03f5-10f6-4d38-9ff4-a80b81da590d;Ip=[192.88.168.50];Helo=[tx30smr01.am.freescale.net]
X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR0301MB1219
X-Microsoft-Exchange-Diagnostics: 1;BN3PR0301MB1217;2:XBszSIKmnrSwV3e1ftirVt1FUhQ0sbFT9T4BopfqFhU2kVWgRsr0VQMXjcjxVQLg;3:q+axfcfubR4BWv0M0Errt0CpHambqFkxMRVgyCDSaLwl5H+MFQOi1SPjU6GzIf15fQeczlPUnBexoSdknO6b1dxN+u98Y7Bnw5ycq3Yn3wKoTHnOIYqPhDVUDy9vQpwRflwLMABKUZdj0dZBtzwMaxvTMCX8Xi4CojIjQq2xqP9Fw1uVeYXO0cuBboonMfOBos/Msu/2Oq8w9Rz5+oDeUT37KUQ73OXVKpNR+a7D4Rg=;25:rzTd3sBRlNqARY//RniwO7GTIQIkxRs2My3gzJCG1KRIY8onNhdHAQWvaWRFhZG0LEcfd2s719Nq7mAS/FogDku7bhmMtGMhorQGaKoNiVzOx9fBPNoJQEAT6yFp1+pAczkygu/yNXbgESQwK+CRN0Yuy/LJfAgMh9YMjsihUMGji3SutZXpqszQgfmpfME2gjUuJ7XQIeKTH6MjEixgbzr/TmHZMm+YrpiAaIWrCz57Ih2NtX121VoQeqt4GkZH8dTMjWXwietQrUKkNjIAGQ==;23:gOqGOok43jLLtZ2sFxiPiddZnH5SR5uwrilBMEI9fWUxzLtgd3Q0GTVVsUkqFwoXY/bSoTTyBg8NXgyFOReAyKwtHD/UYzVaxWlyVjJeCYPGSTyrklPMslOBM5eYv4nQ3JMgs38/jtzavyKJdZLmH5+vx32mUI6/L4VUFM3fibFbcxWUPG9Xs+PezNBq712DFXxRQEDd1SwW6HenobG0RAgDavDukeMFEwsu79vh24ApBRSdMSz/NHgMneQRqiax
X-OriginatorOrg: freescale.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1631
Lines: 54

On Wed, Jul 08, 2015 at 01:19:32PM +0300, Roger Quadros wrote:
> The OTG core will use struct otg_gadget_ops to
> start/stop the gadget controller.
> 
> The main purpose of this interface is to avoid directly
> calling usb_gadget_start/stop() from the OTG core as they
> wouldn't be defined in the built-in symbol table if
> CONFIG_USB_GADGET is m.
> 
> Signed-off-by: Roger Quadros <rogerq@ti.com>
> ---
>  include/linux/usb/gadget.h | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/include/linux/usb/gadget.h b/include/linux/usb/gadget.h
> index 4f3dfb7..0b4b341 100644
> --- a/include/linux/usb/gadget.h
> +++ b/include/linux/usb/gadget.h
> @@ -887,6 +887,20 @@ struct usb_gadget_driver {
>  };
>  
>  
> +/*-------------------------------------------------------------------------*/
> +
> +/**
> + * struct otg_gadget_ops - Interface between OTG core and gadget
> + *
> + * Provided by the gadget core to allow the OTG core to start/stop the gadget
> + *
> + * @start: function to start the gadget
> + * @stop: function to stop the gadget
> + */
> +struct otg_gadget_ops {
> +	int (*start)(struct usb_gadget *gadget);
> +	int (*stop)(struct usb_gadget *gadget);
> +};
>  
>  /*-------------------------------------------------------------------------*/
>  
> -- 
> 2.1.4
> 

Reviewed-by: Peter Chen <peter.chen@freescale.com>

-- 

Best Regards,
Peter Chen
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/