Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753525AbbGQBoM (ORCPT ); Thu, 16 Jul 2015 21:44:12 -0400 Received: from cdptpa-outbound-snat.email.rr.com ([107.14.166.229]:65106 "EHLO cdptpa-oedge-vip.email.rr.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751403AbbGQBoL (ORCPT ); Thu, 16 Jul 2015 21:44:11 -0400 Date: Thu, 16 Jul 2015 21:44:36 -0400 From: Steven Rostedt To: Jungseok Lee Cc: mingo@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] tracing: Fix function graph duration format for 7-digit number Message-ID: <20150716214436.741dff47@grimm.local.home> In-Reply-To: <1436626300-1679-2-git-send-email-jungseoklee85@gmail.com> References: <1436626300-1679-1-git-send-email-jungseoklee85@gmail.com> <1436626300-1679-2-git-send-email-jungseoklee85@gmail.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.25; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-RR-Connecting-IP: 107.14.168.118:25 X-Cloudmark-Score: 0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1620 Lines: 50 On Sat, 11 Jul 2015 14:51:39 +0000 Jungseok Lee wrote: > diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c > index 8968bf7..0bc16c4 100644 > --- a/kernel/trace/trace_functions_graph.c > +++ b/kernel/trace/trace_functions_graph.c > @@ -716,6 +716,8 @@ trace_print_graph_duration(unsigned long long duration, struct trace_seq *s) > snprintf(nsecs_str, slen, "%03lu", nsecs_rem); > trace_seq_printf(s, ".%s", nsecs_str); > len += strlen(nsecs_str); > + } else if (len == 7) { > + len -= 1; Don't you mean len--; > } > > trace_seq_puts(s, " us "); I don't care much for an extra branch here. I'm going to go with the following patch: -- Steve diff --git a/kernel/trace/trace_functions_graph.c b/kernel/trace/trace_functions_graph.c index 8968bf720c12..ca98445782ac 100644 --- a/kernel/trace/trace_functions_graph.c +++ b/kernel/trace/trace_functions_graph.c @@ -715,13 +715,13 @@ trace_print_graph_duration(unsigned long long duration, struct trace_seq *s) snprintf(nsecs_str, slen, "%03lu", nsecs_rem); trace_seq_printf(s, ".%s", nsecs_str); - len += strlen(nsecs_str); + len += strlen(nsecs_str) + 1; } trace_seq_puts(s, " us "); /* Print remaining spaces to fit the row's width */ - for (i = len; i < 7; i++) + for (i = len; i < 8; i++) trace_seq_putc(s, ' '); } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/