Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932374AbbGQGuc (ORCPT ); Fri, 17 Jul 2015 02:50:32 -0400 Received: from mail-ig0-f176.google.com ([209.85.213.176]:37535 "EHLO mail-ig0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755897AbbGQGub (ORCPT ); Fri, 17 Jul 2015 02:50:31 -0400 MIME-Version: 1.0 In-Reply-To: References: <1437069533-22103-1-git-send-email-msalter@redhat.com> Date: Fri, 17 Jul 2015 08:50:30 +0200 Message-ID: Subject: Re: [PATCH] arm64: remove dead code From: Ard Biesheuvel To: Mark Salter , Takahiro Akashi , Geoff Levand Cc: Catalin Marinas , Will Deacon , Mark Rutland , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2162 Lines: 65 (use Geoff's correct email address) On 17 July 2015 at 08:49, Ard Biesheuvel wrote: > (adding Geoff and Takahiro) > > On 16 July 2015 at 19:58, Mark Salter wrote: >> Commit 68234df4ea79 ("arm64: kill flush_cache_all()") removed >> soft_reset() from the kernel. This was the only caller of >> setup_mm_for_reboot(), so remove that also. >> > > I am wondering if setup_mm_for_reboot() is being used in the kexec > patches. Perhaps we should check that before removing it. > > Geoff? > > >> Signed-off-by: Mark Salter >> --- >> arch/arm64/include/asm/mmu.h | 1 - >> arch/arm64/mm/mmu.c | 11 ----------- >> 2 files changed, 12 deletions(-) >> >> diff --git a/arch/arm64/include/asm/mmu.h b/arch/arm64/include/asm/mmu.h >> index 79fcfb0..0302087 100644 >> --- a/arch/arm64/include/asm/mmu.h >> +++ b/arch/arm64/include/asm/mmu.h >> @@ -28,7 +28,6 @@ typedef struct { >> #define ASID(mm) ((mm)->context.id & 0xffff) >> >> extern void paging_init(void); >> -extern void setup_mm_for_reboot(void); >> extern void __iomem *early_io_map(phys_addr_t phys, unsigned long virt); >> extern void init_mem_pgprot(void); >> extern void create_pgd_mapping(struct mm_struct *mm, phys_addr_t phys, >> diff --git a/arch/arm64/mm/mmu.c b/arch/arm64/mm/mmu.c >> index a4ede4e..63012fe 100644 >> --- a/arch/arm64/mm/mmu.c >> +++ b/arch/arm64/mm/mmu.c >> @@ -461,17 +461,6 @@ void __init paging_init(void) >> } >> >> /* >> - * Enable the identity mapping to allow the MMU disabling. >> - */ >> -void setup_mm_for_reboot(void) >> -{ >> - cpu_set_reserved_ttbr0(); >> - flush_tlb_all(); >> - cpu_set_idmap_tcr_t0sz(); >> - cpu_switch_mm(idmap_pg_dir, &init_mm); >> -} >> - >> -/* >> * Check whether a kernel address is valid (derived from arch/x86/). >> */ >> int kern_addr_valid(unsigned long addr) >> -- >> 2.4.3 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/