Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757086AbbGQH0D (ORCPT ); Fri, 17 Jul 2015 03:26:03 -0400 Received: from mail-pd0-f182.google.com ([209.85.192.182]:32779 "EHLO mail-pd0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757015AbbGQH0A (ORCPT ); Fri, 17 Jul 2015 03:26:00 -0400 Date: Fri, 17 Jul 2015 16:12:04 +0900 From: Namhyung Kim To: "Liang, Kan" Cc: "acme@kernel.org" , "jolsa@kernel.org" , "ak@linux.intel.com" , "linux-kernel@vger.kernel.org" , "Hunter, Adrian" Subject: Re: [PATCH RFC V3 3/5] perf,tool: partial time support Message-ID: <20150717071204.GA25386@sejong> References: <1436345097-11113-1-git-send-email-kan.liang@intel.com> <1436345097-11113-4-git-send-email-kan.liang@intel.com> <20150713132742.GA9917@danjae.kornet> <37D7C6CF3E00A74B8858931C1DB2F0770188BEF4@SHSMSX103.ccr.corp.intel.com> <20150714010449.GB16880@danjae.kornet> <37D7C6CF3E00A74B8858931C1DB2F0770188D0BB@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F0770188D0BB@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.5.23+89 (0255b37be491) (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 905 Lines: 25 Hi, On Wed, Jul 15, 2015 at 07:03:38PM +0000, Liang, Kan wrote: > > However, perf_evlist__id_hdr_size() seems to be affected also. Are you > > sure it's okay too? > > > Yes. > id_hdr_size is calculated according to the first event. It impacts > perf tool generated COMM, MMAP and FORK events. > But all of these events have same and position fixed IDENTIFIER, 0. > When parsing the events by perf_evlist__event2evsel, id 0 always > return first event. > So only first event will be involved to parse perf tool generated > COMM, MMAP and FORK events. TIME setting from other events > doesn’t impact. Good. Thanks for the explanation.. Thanks, Namhyung -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/