Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932158AbbGQHRB (ORCPT ); Fri, 17 Jul 2015 03:17:01 -0400 Received: from mail-vn0-f47.google.com ([209.85.216.47]:36686 "EHLO mail-vn0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757100AbbGQHQ7 (ORCPT ); Fri, 17 Jul 2015 03:16:59 -0400 MIME-Version: 1.0 In-Reply-To: <1437019057.16262.22.camel@perches.com> References: <1436985972-5431-1-git-send-email-simhavcs@gmail.com> <1437019057.16262.22.camel@perches.com> Date: Fri, 17 Jul 2015 12:46:58 +0530 Message-ID: Subject: Re: [PATCH] sm750fb: coding style fixes lines over 80 chars From: Vinay Simha To: Joe Perches Cc: Sudip Mukherjee , Teddy Wang , Greg Kroah-Hartman , "open list:STAGING - SILICON MOTION SM750 FRAME BUFFER DRIVER" , "open list:STAGING SUBSYSTEM" , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1212 Lines: 42 #if 0, but it's also obviously incorrect It supposed to be some tag #ifdef CONFIG_** . Could anybody in the loop can reply? i was just checking on style checks. Will skip this file , will take up later On Thu, Jul 16, 2015 at 9:27 AM, Joe Perches wrote: > On Thu, 2015-07-16 at 00:16 +0530, Vinay Simha BN wrote: >> scripts/checkpatch.pl kernel coding style fixes of WARNING > > Please don't be a checkpatch robot. > > Use tools to prompt your brain, but don't ever turn > your brain off. > >> diff --git a/drivers/staging/sm750fb/ddk750_help.h b/drivers/staging/sm750fb/ddk750_help.h > > >> +/* if 718 big endian turned on,be aware that don't use this driver for general >> + use,only for ppc big-endian */ >> +#warning "big endian on target cpu and enable nature big endian support of 718 >> + capability !" > > Yes, this if #if 0, but it's also obviously incorrect > > I didn't look at the rest. > > -- Regards, Vinay Simha.B.N. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/