Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757057AbbGQHt1 (ORCPT ); Fri, 17 Jul 2015 03:49:27 -0400 Received: from mail-oi0-f54.google.com ([209.85.218.54]:33675 "EHLO mail-oi0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbbGQHtZ (ORCPT ); Fri, 17 Jul 2015 03:49:25 -0400 MIME-Version: 1.0 In-Reply-To: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> References: <1436447993-24630-1-git-send-email-k.kozlowski.k@gmail.com> Date: Fri, 17 Jul 2015 09:49:24 +0200 Message-ID: Subject: Re: [RFT PATCH] gpio: etraxfs: Fix devm_ioremap_resource return value check From: Linus Walleij To: Krzysztof Kozlowski , Rabin Vincent Cc: Alexandre Courbot , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" , stable Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 767 Lines: 20 On Thu, Jul 9, 2015 at 3:19 PM, Krzysztof Kozlowski wrote: > Value returned by devm_ioremap_resource() was checked for non-NULL but > devm_ioremap_resource() returns IOMEM_ERR_PTR, not NULL. In case of > error this could lead to dereference of ERR_PTR. > > Signed-off-by: Krzysztof Kozlowski > Fixes: d342571efea8 ("gpio: add ETRAXFS GPIO driver") > Cc: Patch applied for next cycle, stripped the Fixes: and stable tags. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/