Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946292AbbGQJIy (ORCPT ); Fri, 17 Jul 2015 05:08:54 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:56712 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932213AbbGQIso (ORCPT ); Fri, 17 Jul 2015 04:48:44 -0400 X-AuditID: cbfee61a-f79516d000006302-be-55a8c16116f0 From: Jacek Anaszewski To: linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, stsp@users.sourceforge.net, Andrew Lunn , Antonio Ospite Subject: [PATCH/RFC 15/51] leds: lp3944: Remove work queue Date: Fri, 17 Jul 2015 10:47:01 +0200 Message-id: <1437122857-6765-16-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1437122857-6765-1-git-send-email-j.anaszewski@samsung.com> References: <1437122857-6765-1-git-send-email-j.anaszewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprGLMWRmVeSWpSXmKPExsVy+t9jAd3EgytCDa584rY4f/cQs8XRnROZ LC7vmsNmsfXNOkaL3927WSx273rKatHZN43Fgd1j56y7QGLHZyaPPfN/sHocurCOxaPpVDur x+dNcgFsUVw2Kak5mWWpRfp2CVwZE/YeZyzYJ1Sx63JMA+Ns/i5GDg4JAROJyb8Duhg5gUwx iQv31rN1MXJxCAksYpS4feQAK4Tzk1Fi+4uzLCBVbAKGEj9fvGYCaRYRkJPYeaYSpIZZYAOj xJlXzUwgNcICVhKX19xiA7FZBFQlul7sALN5BTwkZn04xA6xWEFiziQbkDAnUPj9g5Vg44UE 3CXa/lxkm8DIu4CRYRWjaGpBckFxUnquoV5xYm5xaV66XnJ+7iZGcGg9k9rBuLLB4hCjAAej Eg9vg+uKUCHWxLLiytxDjBIczEoivJU7gUK8KYmVValF+fFFpTmpxYcYpTlYlMR5T+b7hAoJ pCeWpGanphakFsFkmTg4pRoYLTuV94mdrpL3vubvwq3IadtS9LLwx8Lbzz8az/x9xkvJteP9 h/7Hj0u0z375POnQ632c1ZOOvP7K91vriok0/+zkm9MVFCICL/1TXJjzll98wt+s9wJ/lbwC X2fdyvQVObKq7/O8e7eYX9TfFH7wdrrSVm/GPd8ZfnXs+JVeq+E48f/C5wuTDiixFGckGmox FxUnAgC+ht6qKQIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2530 Lines: 86 From: Andrew Lunn Now the core implements the work queue, remove it from the driver. Signed-off-by: Andrew Lunn Cc: Antonio Ospite --- drivers/leds/leds-lp3944.c | 15 +-------------- 1 file changed, 1 insertion(+), 14 deletions(-) diff --git a/drivers/leds/leds-lp3944.c b/drivers/leds/leds-lp3944.c index 53144fb..c5cb4b9 100644 --- a/drivers/leds/leds-lp3944.c +++ b/drivers/leds/leds-lp3944.c @@ -31,7 +31,6 @@ #include #include #include -#include #include /* Read Only Registers */ @@ -71,7 +70,6 @@ struct lp3944_led_data { enum lp3944_status status; struct led_classdev ldev; struct i2c_client *client; - struct work_struct work; }; struct lp3944_data { @@ -276,7 +274,7 @@ static int lp3944_led_set_blink(struct led_classdev *led_cdev, __func__); led->status = LP3944_LED_STATUS_DIM0; - schedule_work(&led->work); + lp3944_led_set(led, led->status); return 0; } @@ -290,14 +288,6 @@ static void lp3944_led_set_brightness(struct led_classdev *led_cdev, __func__, led_cdev->name, brightness); led->status = !!brightness; - schedule_work(&led->work); -} - -static void lp3944_led_work(struct work_struct *work) -{ - struct lp3944_led_data *led; - - led = container_of(work, struct lp3944_led_data, work); lp3944_led_set(led, led->status); } @@ -325,7 +315,6 @@ static int lp3944_configure(struct i2c_client *client, led->ldev.blink_set = lp3944_led_set_blink; led->ldev.flags = LED_CORE_SUSPENDRESUME; - INIT_WORK(&led->work, lp3944_led_work); err = led_classdev_register(&client->dev, &led->ldev); if (err < 0) { dev_err(&client->dev, @@ -364,7 +353,6 @@ exit: case LP3944_LED_TYPE_LED: case LP3944_LED_TYPE_LED_INVERTED: led_classdev_unregister(&data->leds[i].ldev); - cancel_work_sync(&data->leds[i].work); break; case LP3944_LED_TYPE_NONE: @@ -424,7 +412,6 @@ static int lp3944_remove(struct i2c_client *client) case LP3944_LED_TYPE_LED: case LP3944_LED_TYPE_LED_INVERTED: led_classdev_unregister(&data->leds[i].ldev); - cancel_work_sync(&data->leds[i].work); break; case LP3944_LED_TYPE_NONE: -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/