Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945982AbbGQItW (ORCPT ); Fri, 17 Jul 2015 04:49:22 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:60014 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1945960AbbGQItR (ORCPT ); Fri, 17 Jul 2015 04:49:17 -0400 X-AuditID: cbfee61b-f79416d0000014c0-1f-55a8c18cf12d From: Jacek Anaszewski To: linux-leds@vger.kernel.org Cc: linux-kernel@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, stsp@users.sourceforge.net, Jacek Anaszewski , Raphael Assenat Subject: [PATCH/RFC 30/51] leds: pwm: remove work queue Date: Fri, 17 Jul 2015 10:47:16 +0200 Message-id: <1437122857-6765-31-git-send-email-j.anaszewski@samsung.com> X-Mailer: git-send-email 1.7.9.5 In-reply-to: <1437122857-6765-1-git-send-email-j.anaszewski@samsung.com> References: <1437122857-6765-1-git-send-email-j.anaszewski@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprBLMWRmVeSWpSXmKPExsVy+t9jAd2egytCDf6fFrI4unMik0Xv1eeM Fpd3zWGz2PpmHaPF0zO3GC1273rKatHZN43Fgd3j/+ZFjB47Z91l99gz/werR9+WVYweTafa WT0+b5ILYIvisklJzcksSy3St0vgyljb1MdY8EyoYtWRj4wNjDf4uxg5OSQETCQ6Pp1khrDF JC7cW8/WxcjFISSwiFHi3fPP7BDOT0aJlcdPM4JUsQkYSvx88Zqpi5GDQ0RATmLnmUqQGmaB zYwSv28/YAGpERYwl3jU/ZMVxGYRUJX48Wc6O4jNK+AhsXL7ezaQXgkBBYk5k2xAwpxA4fcP VoK1Cgm4S7T9ucg2gZF3ASPDKkbR1ILkguKk9FwjveLE3OLSvHS95PzcTYzg8HomvYNxVYPF IUYBDkYlHt4G1xWhQqyJZcWVuYcYJTiYlUR4K3cChXhTEiurUovy44tKc1KLDzFKc7AoifOe zPcJFRJITyxJzU5NLUgtgskycXBKNTAyM/9/aJv8KvzjP5afHk8/lOpteVZv+vQGs/Lkcobl u3dtlMwxfX5AM7SY/aOyfdzcwr9NnzkbJARnvnkz+fClo59uvX11SylpigLzJL/drZqe3A1y IX6R7L1zw2x37yk+cVnuY/mdhjeqtwwDLtwUP9RkP+2u8bVPj0osHvTK9Ub9n8oRX92hxFKc kWioxVxUnAgAifUnHisCAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2570 Lines: 86 Now the core implements the work queue, remove it from the drivers. If brightness setting is guaranteed not to sleep then set the flag LED_BRIGHTNESS_FAST. Signed-off-by: Jacek Anaszewski Cc: Raphael Assenat --- drivers/leds/leds-pwm.c | 24 ++++-------------------- 1 file changed, 4 insertions(+), 20 deletions(-) diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c index 1d07e3e..0068297 100644 --- a/drivers/leds/leds-pwm.c +++ b/drivers/leds/leds-pwm.c @@ -22,12 +22,10 @@ #include #include #include -#include struct led_pwm_data { struct led_classdev cdev; struct pwm_device *pwm; - struct work_struct work; unsigned int active_low; unsigned int period; int duty; @@ -51,14 +49,6 @@ static void __led_pwm_set(struct led_pwm_data *led_dat) pwm_enable(led_dat->pwm); } -static void led_pwm_work(struct work_struct *work) -{ - struct led_pwm_data *led_dat = - container_of(work, struct led_pwm_data, work); - - __led_pwm_set(led_dat); -} - static void led_pwm_set(struct led_classdev *led_cdev, enum led_brightness brightness) { @@ -75,10 +65,7 @@ static void led_pwm_set(struct led_classdev *led_cdev, led_dat->duty = duty; - if (led_dat->can_sleep) - schedule_work(&led_dat->work); - else - __led_pwm_set(led_dat); + __led_pwm_set(led_dat); } static inline size_t sizeof_pwm_leds_priv(int num_leds) @@ -89,11 +76,8 @@ static inline size_t sizeof_pwm_leds_priv(int num_leds) static void led_pwm_cleanup(struct led_pwm_priv *priv) { - while (priv->num_leds--) { + while (priv->num_leds--) led_classdev_unregister(&priv->leds[priv->num_leds].cdev); - if (priv->leds[priv->num_leds].can_sleep) - cancel_work_sync(&priv->leds[priv->num_leds].work); - } } static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, @@ -122,8 +106,8 @@ static int led_pwm_add(struct device *dev, struct led_pwm_priv *priv, } led_data->can_sleep = pwm_can_sleep(led_data->pwm); - if (led_data->can_sleep) - INIT_WORK(&led_data->work, led_pwm_work); + if (!led_data->can_sleep) + led_data->cdev.flags |= LED_BRIGHTNESS_FAST; led_data->period = pwm_get_period(led_data->pwm); if (!led_data->period && (led->pwm_period_ns > 0)) -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/