Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964813AbbGQJEo (ORCPT ); Fri, 17 Jul 2015 05:04:44 -0400 Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:50247 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1946095AbbGQJEl (ORCPT ); Fri, 17 Jul 2015 05:04:41 -0400 Message-ID: <1437123868.24981.7.camel@tiscali.nl> Subject: Re: [PATCH 7/7] mtd: atmel-quadspi: add driver for Atmel QSPI controller From: Paul Bolle To: Cyrille Pitchen Cc: nicolas.ferre@atmel.com, broonie@kernel.org, linux-spi@vger.kernel.org, dwmw2@infradead.org, computersforpeace@gmail.com, zajec5@gmail.com, beanhuo@micron.com, juhosg@openwrt.org, marex@denx.de, shijie.huang@intel.com, ben@decadent.org.uk, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux-mtd@lists.infradead.org Date: Fri, 17 Jul 2015 11:04:28 +0200 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.3 (3.16.3-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 749 Lines: 25 On do, 2015-07-16 at 17:27 +0200, Cyrille Pitchen wrote: > --- /dev/null > +++ b/drivers/mtd/spi-nor/atmel-quadspi.c > +static struct platform_driver atmel_qspi_driver = { > + .driver = { > + [...] > + .bus = &platform_bus_type, > + [...] > +}; > +module_platform_driver(atmel_qspi_driver); Nit: on module init this will basically do __platform_driver_register(&atmel_qspi_driver, THIS_MODULE); which will again set bus to &platform_bus_type. So you might as well drop that line. Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/