Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1946262AbbGQJHV (ORCPT <rfc822;w@1wt.eu>);
	Fri, 17 Jul 2015 05:07:21 -0400
Received: from mail-wg0-f50.google.com ([74.125.82.50]:32856 "EHLO
	mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756414AbbGQJHQ (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 17 Jul 2015 05:07:16 -0400
Date: Fri, 17 Jul 2015 11:07:13 +0200
From: Luis de Bethencourt <luis@debethencourt.com>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc: linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Frans Klaver <fransklaver@gmail.com>,
        Antoine Schweitzer-Chaput <antoine@schweitzer-chaput.fr>,
        Cristina Opriceana <cristina.opriceana@gmail.com>,
        Aya Mahfouz <mahfouz.saif.elyazal@gmail.com>,
        Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
        Koray Gulcu <koray.gulcu@ozu.edu.tr>, Greg Donald <gdonald@gmail.com>,
        Lorenzo Stoakes <lstoakes@gmail.com>,
        Ebru Akagunduz <ebru.akagunduz@gmail.com>,
        Karthik Nayak <karthik.188@gmail.com>, devel@driverdev.osuosl.org
Subject: Re: [PATCH v4] staging: rtl8192u: remove bool comparisons
Message-ID: <20150717090713.GA887@goodgumbo.baconseed.org>
References: <20150716134949.GA27865@goodgumbo.baconseed.org>
 <20150717060445.GA8422@sudip-PC>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150717060445.GA8422@sudip-PC>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1489
Lines: 44

On Fri, Jul 17, 2015 at 11:34:45AM +0530, Sudip Mukherjee wrote:
> On Thu, Jul 16, 2015 at 03:49:49PM +0200, Luis de Bethencourt wrote:
> > Remove explicit true/false comparisons to bool variables.
> > 
> > Signed-off-by: Luis de Bethencourt <luis@debethencourt.com>
> > ---
> <snip>
> >
> > diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> > index b852396..41cf99d 100644
> > --- a/drivers/staging/rtl8192u/r8192U_core.c
> > +++ b/drivers/staging/rtl8192u/r8192U_core.c
> > @@ -2043,16 +2043,10 @@ static bool GetNmodeSupportBySecCfg8192(struct net_device *dev)
> >  
> >  static bool GetHalfNmodeSupportByAPs819xUsb(struct net_device *dev)
> >  {
> > -	bool			Reval;
> >  	struct r8192_priv *priv = ieee80211_priv(dev);
> >  	struct ieee80211_device *ieee = priv->ieee80211;
> >  
> > -	if (ieee->bHalfWirelessN24GMode == true)
> > -		Reval = true;
> > -	else
> > -		Reval =  false;
> > -
> > -	return Reval;
> > +	return ieee->bHalfWirelessN24GMode;
> I think this should have been in a separate patch.
> 
> regards
> sudip

That's a good point. It is related but a different fix than removing booolean
comparisons.

Thanks once again for review Sudip :)

Going to send a new version soon,
Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/