Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932524AbbGQJKt (ORCPT ); Fri, 17 Jul 2015 05:10:49 -0400 Received: from www.linutronix.de ([62.245.132.108]:46310 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932405AbbGQJKq (ORCPT ); Fri, 17 Jul 2015 05:10:46 -0400 Date: Fri, 17 Jul 2015 11:10:11 +0200 (CEST) From: Thomas Gleixner To: Tang Chen cc: mingo@redhat.com, hpa@zytor.com, akpm@linux-foundation.org, tj@kernel.org, dyoung@redhat.com, isimatu.yasuaki@jp.fujitsu.com, yasu.isimatu@gmail.com, lcapitulino@redhat.com, qiuxishi@huawei.com, will.deacon@arm.com, tony.luck@intel.com, vladimir.murzin@arm.com, fabf@skynet.be, kuleshovmail@gmail.com, bhe@redhat.com, x86@kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mem-hotplug: Handle node hole when initializing numa_meminfo. In-Reply-To: <1437096211-28605-3-git-send-email-tangchen@cn.fujitsu.com> Message-ID: References: <1437096211-28605-1-git-send-email-tangchen@cn.fujitsu.com> <1437096211-28605-3-git-send-email-tangchen@cn.fujitsu.com> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 29 On Fri, 17 Jul 2015, Tang Chen wrote: > diff --git a/include/linux/memblock.h b/include/linux/memblock.h > index d312ae3..c518eb5 100644 > --- a/include/linux/memblock.h > +++ b/include/linux/memblock.h > @@ -77,6 +77,8 @@ int memblock_remove(phys_addr_t base, phys_addr_t size); > int memblock_free(phys_addr_t base, phys_addr_t size); > int memblock_reserve(phys_addr_t base, phys_addr_t size); > void memblock_trim_memory(phys_addr_t align); > +bool memblock_overlaps_region(struct memblock_type *type, > + phys_addr_t base, phys_addr_t size); > -static bool __init_memblock memblock_overlaps_region(struct memblock_type *type, > +bool __init_memblock memblock_overlaps_region(struct memblock_type *type, > phys_addr_t base, phys_addr_t size) > { > unsigned long i; This is silly. You change that function in the first patch already, so why don't you make it globally visible there and then have the user. Other than that: Acked-by: Thomas Gleixner -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/