Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1946164AbbGQJUc (ORCPT ); Fri, 17 Jul 2015 05:20:32 -0400 Received: from mail-lb0-f178.google.com ([209.85.217.178]:33611 "EHLO mail-lb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932309AbbGQJUa (ORCPT ); Fri, 17 Jul 2015 05:20:30 -0400 Date: Fri, 17 Jul 2015 11:20:26 +0200 From: Johan Hovold To: Jacek Anaszewski Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org, cooloney@gmail.com, rpurdie@rpsys.net, stsp@users.sourceforge.net, Andrew Lunn , Johan Hovold Subject: Re: [PATCH/RFC 12/51] leds: lm3533: Remove work queue Message-ID: <20150717092026.GA28850@localhost> References: <1437122857-6765-1-git-send-email-j.anaszewski@samsung.com> <1437122857-6765-13-git-send-email-j.anaszewski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437122857-6765-13-git-send-email-j.anaszewski@samsung.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1924 Lines: 63 On Fri, Jul 17, 2015 at 10:46:58AM +0200, Jacek Anaszewski wrote: > From: Andrew Lunn > > Now the core implements the work queue, remove it from the driver. > > Signed-off-by: Andrew Lunn > Signed-off-by: Jacek Anaszewski > Cc: Johan Hovold > --- > drivers/leds/leds-lm3533.c | 30 ++++++------------------------ > 1 file changed, 6 insertions(+), 24 deletions(-) > > diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c > index 6e2e020..52496d8 100644 > --- a/drivers/leds/leds-lm3533.c > +++ b/drivers/leds/leds-lm3533.c > @@ -17,7 +17,6 @@ > @@ -123,27 +119,17 @@ out: > return ret; > } > > -static void lm3533_led_work(struct work_struct *work) > -{ > - struct lm3533_led *led = container_of(work, struct lm3533_led, work); > - > - dev_dbg(led->cdev.dev, "%s - %u\n", __func__, led->new_brightness); > - > - if (led->new_brightness == 0) > - lm3533_led_pattern_enable(led, 0); /* disable blink */ > - > - lm3533_ctrlbank_set_brightness(&led->cb, led->new_brightness); > -} > - > static void lm3533_led_set(struct led_classdev *cdev, > - enum led_brightness value) > + enum led_brightness value) Unrelated random white-space change. > { > struct lm3533_led *led = to_lm3533_led(cdev); > > - dev_dbg(led->cdev.dev, "%s - %d\n", __func__, value); > + dev_dbg(led->cdev.dev, "%s - %u\n", __func__, value); Also an unrelated change. > + > + if (value == 0) > + lm3533_led_pattern_enable(led, 0); /* disable blink */ > > - led->new_brightness = value; > - schedule_work(&led->work); > + lm3533_ctrlbank_set_brightness(&led->cb, value); > } Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/