Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757469AbbGQJYI (ORCPT ); Fri, 17 Jul 2015 05:24:08 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32943 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757449AbbGQJYF (ORCPT ); Fri, 17 Jul 2015 05:24:05 -0400 Date: Fri, 17 Jul 2015 11:23:57 +0200 From: Jiri Olsa To: kan.liang@intel.com Cc: acme@kernel.org, jolsa@kernel.org, namhyung@kernel.org, ak@linux.intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC V4 1/4] perf,tools: introduce callgraph_set for callgraph option Message-ID: <20150717092357.GA1057@krava.redhat.com> References: <1437035170-12911-1-git-send-email-kan.liang@intel.com> <1437035170-12911-2-git-send-email-kan.liang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437035170-12911-2-git-send-email-kan.liang@intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2160 Lines: 70 On Thu, Jul 16, 2015 at 04:26:07AM -0400, kan.liang@intel.com wrote: > From: Kan Liang > > Introduce callgraph_set to indicate whether the callgraph option was set > by user. > > Signed-off-by: Kan Liang > --- > tools/perf/builtin-record.c | 6 ++++-- > tools/perf/perf.h | 1 + > 2 files changed, 5 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/builtin-record.c b/tools/perf/builtin-record.c > index 283fe96..1d40be9 100644 > --- a/tools/perf/builtin-record.c > +++ b/tools/perf/builtin-record.c > @@ -762,12 +762,13 @@ static void callchain_debug(void) > callchain_param.dump_size); > } > > -int record_parse_callchain_opt(const struct option *opt __maybe_unused, > +int record_parse_callchain_opt(const struct option *opt, > const char *arg, > int unset) > { > int ret; > > + *(bool *)opt->set = true; > callchain_param.enabled = !unset; > > /* --no-call-graph */ > @@ -784,10 +785,11 @@ int record_parse_callchain_opt(const struct option *opt __maybe_unused, > return ret; > } > > -int record_callchain_opt(const struct option *opt __maybe_unused, > +int record_callchain_opt(const struct option *opt, > const char *arg __maybe_unused, > int unset __maybe_unused) > { > + *(bool *)opt->set = true; hum, how does this set callgraph_set ? shouldn't it be 'callgraph_set = true' instead? jirka > callchain_param.enabled = true; > > if (callchain_param.record_mode == CALLCHAIN_NONE) > diff --git a/tools/perf/perf.h b/tools/perf/perf.h > index 937b16a..9ba02e0 100644 > --- a/tools/perf/perf.h > +++ b/tools/perf/perf.h > @@ -52,6 +52,7 @@ struct record_opts { > bool sample_weight; > bool sample_time; > bool sample_time_set; > + bool callgraph_set; > bool period; > bool sample_intr_regs; > bool running_time; > -- > 1.8.3.1 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/