Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757370AbbGQJhn (ORCPT ); Fri, 17 Jul 2015 05:37:43 -0400 Received: from mail-lb0-f171.google.com ([209.85.217.171]:32932 "EHLO mail-lb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751190AbbGQJhl (ORCPT ); Fri, 17 Jul 2015 05:37:41 -0400 MIME-Version: 1.0 In-Reply-To: References: <20150714131704.21442.17939.stgit@buzz> <20150714131705.21442.99279.stgit@buzz> Date: Fri, 17 Jul 2015 12:37:40 +0300 Message-ID: Subject: Re: [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime From: Konstantin Khlebnikov To: Christoph Lameter Cc: Konstantin Khlebnikov , "linux-mm@kvack.org" , Andrew Morton , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1166 Lines: 28 On Wed, Jul 15, 2015 at 12:18 AM, Christoph Lameter wrote: > > On Tue, 14 Jul 2015, Konstantin Khlebnikov wrote: >> > What breaks? >> >> The same commands from first patch: >> >> # echo 1 | tee /sys/kernel/slab/*/sanity_checks >> # modprobe configfs >> >> loading configfs now fails (without crashing kernel though) because of >> "sysfs: cannot create duplicate filename '/kernel/slab/:t-0000096'" > > Hrm.... Bad. Maybe drop the checks for the debug options that can be > configured when merging slabs? They do not influence the object layout > per definition. I don't understand that. Debug options do changes in object layout. Since they add significant performance overhead and cannot be undone in runtime it's unlikely that anyone who uses them don't care about merging after that. Also I don't see how merging could affect debugging in positive way (except debugging bugs in merging logic itself). -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/