Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757687AbbGQK0l (ORCPT ); Fri, 17 Jul 2015 06:26:41 -0400 Received: from orbit.nwl.cc ([176.31.251.142]:56452 "EHLO mail.nwl.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756674AbbGQK0i (ORCPT ); Fri, 17 Jul 2015 06:26:38 -0400 Date: Fri, 17 Jul 2015 12:26:36 +0200 From: Phil Sutter To: Thomas Graf Cc: Meelis Roos , sparclinux@vger.kernel.org, Linux Kernel list , netdev@vger.kernel.org, "David S. Miller" , Herbert Xu , Daniel Borkmann , Geert Uytterhoeven Subject: Re: 4.1 regression in resizable hashtable tests Message-ID: <20150717102636.GA21732@orbit.nwl.cc> Mail-Followup-To: Thomas Graf , Meelis Roos , sparclinux@vger.kernel.org, Linux Kernel list , netdev@vger.kernel.org, "David S. Miller" , Herbert Xu , Daniel Borkmann , Geert Uytterhoeven References: <20150702123130.GA20843@pox.localdomain> <20150717080456.GA13814@pox.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150717080456.GA13814@pox.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 43 On Fri, Jul 17, 2015 at 10:04:56AM +0200, Thomas Graf wrote: > On 07/02/15 at 10:09pm, Meelis Roos wrote: > > [ 33.425061] Running rhashtable test nelem=8, max_size=65536, shrinking=0 > > [ 33.425154] Test 00: > > [ 33.534470] Adding 50000 keys > > [ 34.743553] Info: encountered resize > > [ 34.743698] Info: encountered resize > > [ 34.743838] Info: encountered resize > > [ 34.744057] Info: encountered resize > > [ 34.744430] Info: encountered resize > > [ 34.745139] Info: encountered resize > > [ 34.746441] Info: encountered resize > > [ 34.749055] Info: encountered resize > > [ 34.754469] Info: encountered resize > > [ 34.764836] Info: encountered resize > > [ 34.785696] Info: encountered resize > > [ 34.827448] Info: encountered resize > > [ 34.896936] Traversal complete: counted=49993, nelems=50000, entries=50000, table-jumps=12 > > [ 34.897056] Test failed: Total count mismatch ^^^ > > I do see count mismatches as well due to the design of the walker > which restarts and thus sees certain entries multiple times. > > Do you have this commit as well? > > Author: Phil Sutter > Date: Mon Jul 6 15:51:20 2015 +0200 > > rhashtable: fix for resize events during table walk Thomas, this should be resolved already. Meelis replied[1] to my patch, stating it fixes that problem for him. Though he's still waiting for your proposed patch to add a schedule() call so the kernel won't complain on his slow UltraSparc. :) Cheers, Phil [1]: http://www.spinics.net/lists/netdev/msg335767.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/