Date: Fri, 17 Jul 2015 13:39:24 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: kaixu xia <xiakaixu@huawei.com>, ast@plumgrid.com, davem@davemloft.net,
        acme@kernel.org, mingo@redhat.com, masami.hiramatsu.pt@hitachi.com,
        jolsa@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
        hekuang@huawei.com
Subject: Re: [RFC PATCH 5/6] bpf: Implement function bpf_read_pmu() that get
 the selected hardware PMU conuter
Message-ID: <20150717113924.GD19282@twins.programming.kicks-ass.net>
References: <1437129816-13176-1-git-send-email-xiakaixu@huawei.com>
 <1437129816-13176-6-git-send-email-xiakaixu@huawei.com>
 <20150717110541.GJ12596@twins.programming.kicks-ass.net>
 <55A8E703.70306@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55A8E703.70306@huawei.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1485
Lines: 43

On Fri, Jul 17, 2015 at 07:29:07PM +0800, Wangnan (F) wrote:
> 
> 
> On 2015/7/17 19:05, Peter Zijlstra wrote:
> >On Fri, Jul 17, 2015 at 06:43:35PM +0800, kaixu xia wrote:
> >>The function bpf_read_pmu() can get the specific map key, convert
> >>the corresponding map value to the pointer to struct perf_event and
> >>return the Hardware PMU counter value.
> >Thanks for having me on Cc :/
> >
> >>Signed-off-by: kaixu xia <xiakaixu@huawei.com>
> >>---
> >>+static u64 bpf_read_pmu(u64 r1, u64 r2, u64 r3, u64 r4, u64 r5)
> >>+{
> >>+	void *value = (void *) (unsigned long) r1;
> >>+	struct perf_event *event;
> >>+	u64 count;
> >>+
> >>+	if (!value || !(*(unsigned long *)value))
> >>+		return 0;
> >>+
> >>+	event = (struct perf_event *)(*(unsigned long *)value);
> >>+
> >>+	if (event->state == PERF_EVENT_STATE_ACTIVE)
> >>+		event->pmu->read(event);
> >>+
> >>+	count = local64_read(&event->count);
> >>+
> >>+	return count;
> >>+}
> >Hell no, that's way broken.
> What about calling perf_event_read_value() then?

Depends on what all you need, if you need full perf events to work then
yes perf_event_read_value() is your only option.

But note that that requires scheduling, so you cannot actually use it
for tracing purposes etc..
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/