Date: Fri, 17 Jul 2015 13:40:54 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: kaixu xia <xiakaixu@huawei.com>, ast@plumgrid.com, davem@davemloft.net,
        acme@kernel.org, mingo@redhat.com, masami.hiramatsu.pt@hitachi.com,
        jolsa@kernel.org, linux-kernel@vger.kernel.org, pi3orama@163.com,
        hekuang@huawei.com
Subject: Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map
Message-ID: <20150717114054.GE19282@twins.programming.kicks-ass.net>
References: <1437129816-13176-1-git-send-email-xiakaixu@huawei.com>
 <1437129816-13176-4-git-send-email-xiakaixu@huawei.com>
 <20150717110623.GK12596@twins.programming.kicks-ass.net>
 <55A8E554.9040205@huawei.com>
 <55A8E83E.6090506@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55A8E83E.6090506@huawei.com>
User-Agent: Mutt/1.5.21 (2012-12-30)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1430
Lines: 44

On Fri, Jul 17, 2015 at 07:34:22PM +0800, Wangnan (F) wrote:
> On 2015/7/17 19:21, Wangnan (F) wrote:
> >On 2015/7/17 19:06, Peter Zijlstra wrote:
> >>On Fri, Jul 17, 2015 at 06:43:33PM +0800, kaixu xia wrote:
> >>>diff --git a/kernel/events/core.c b/kernel/events/core.c
> >>>index e965cfa..c4e34b7 100644
> >>>--- a/kernel/events/core.c
> >>>+++ b/kernel/events/core.c
> >>>@@ -8582,6 +8582,28 @@ void perf_event_delayed_put(struct task_struct
> >>>*task)
> >>>          WARN_ON_ONCE(task->perf_event_ctxp[ctxn]);
> >>>  }
> >>>  +struct perf_event *perf_event_get(unsigned int fd)
> >>>+{
> >>>+    struct perf_event *event;
> >>>+    struct fd f;
> >>>+
> >>>+    f = fdget(fd);
> >>>+
> >>>+    if (!f.file)
> >>>+        return ERR_PTR(-EBADF);
> >>>+
> >>>+    if (f.file->f_op != &perf_fops) {
> >>>+        fdput(f);
> >>>+        return ERR_PTR(-EINVAL);
> >>>+    }
> >>>+
> >>>+    event = f.file->private_data;
> >>>+
> >>>+    fdput(f);
> >>>+
> >>>+    return event;
> >>>+}
> >>And what is stopping userspace from closing those FDs while you're using
> >>them?

> Shall we put atomic_long_inc_not_zero() between fdget() and fdput()?

You pretty much _have_ to do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/