Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756905AbbGQMMi (ORCPT ); Fri, 17 Jul 2015 08:12:38 -0400 Received: from szxga03-in.huawei.com ([119.145.14.66]:45323 "EHLO szxga03-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756746AbbGQMMh (ORCPT ); Fri, 17 Jul 2015 08:12:37 -0400 Message-ID: <55A8EFF1.3050005@huawei.com> Date: Fri, 17 Jul 2015 20:07:13 +0800 From: "Wangnan (F)" User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Peter Zijlstra CC: kaixu xia , , , , , , , , , Subject: Re: [RFC PATCH 3/6] bpf: Save the pointer to struct perf_event to map References: <1437129816-13176-1-git-send-email-xiakaixu@huawei.com> <1437129816-13176-4-git-send-email-xiakaixu@huawei.com> <20150717110623.GK12596@twins.programming.kicks-ass.net> <55A8E554.9040205@huawei.com> <55A8E83E.6090506@huawei.com> <20150717114054.GE19282@twins.programming.kicks-ass.net> <55A8ED0F.2040208@huawei.com> <20150717120206.GG19282@twins.programming.kicks-ass.net> In-Reply-To: <20150717120206.GG19282@twins.programming.kicks-ass.net> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.111.66.109] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020202.55A8F002.0078,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2013-05-26 15:14:31, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 36a0af16774e39dfb131c88b551a108e Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 751 Lines: 22 On 2015/7/17 20:02, Peter Zijlstra wrote: > On Fri, Jul 17, 2015 at 07:54:55PM +0800, Wangnan (F) wrote: >> Thanks. In next version we will introduce a new function which do oppsite >> thing to >> perf_event_release_kernel() in perf/event/core.c, then fetch the event >> before fdput. > perf_event_get() as proposed, with the addition of the refcount > increment inside the fdget/fdput() is fine. > > Note that the _get() name already implies a refcount increment. OK, you'll see it in v2. Thank you. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/