Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1945990AbbGQMKn (ORCPT ); Fri, 17 Jul 2015 08:10:43 -0400 Received: from mail-wi0-f181.google.com ([209.85.212.181]:33018 "EHLO mail-wi0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751622AbbGQMKl (ORCPT ); Fri, 17 Jul 2015 08:10:41 -0400 Date: Fri, 17 Jul 2015 14:10:37 +0200 From: Ingo Molnar To: Masami Hiramatsu Cc: Pratyush Anand , Ananth N Mavinakayanahalli , Rusty Russell , Linux Kernel Mailing List , Ingo Molnar , Rob Landley , "H. Peter Anvin" , Thomas Gleixner , "David S. Miller" Subject: Re: [PATCH tip/master 1/3] kprobes: Support blacklist functions in module Message-ID: <20150717121037.GA9437@gmail.com> References: <20150716071053.14218.82072.stgit@localhost.localdomain> <20150716071055.14218.64129.stgit@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150716071055.14218.64129.stgit@localhost.localdomain> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1336 Lines: 42 * Masami Hiramatsu wrote: > To blacklist the functions in a module (e.g. user-defined > kprobe handler and the functions invoked from it), expand > blacklist support for modules. > With this change, users can use NOKPROBE_SYMBOL() macro in > their own modules. Btw., whatever happened with renaming '__kprobes' to '__nokprobe' and using that consistently to blacklist certain functions? Also, shouldn't we convert such instances: static int notifier_call_chain(struct notifier_block **nl, unsigned long val, void *v, int nr_to_call, int *nr_calls) ... NOKPROBE_SYMBOL(notifier_call_chain); to: static int __nokprobe notifier_call_chain(struct notifier_block **nl, unsigned long val, void *v, int nr_to_call, int *nr_calls) ? I.e. instead of extending it to modules we should eliminate NOKPROBE_SYMBOL() in favor of marking functions as __nokprobe which is the standard syntax for marking functions. Thanks, Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/