Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757438AbbGQMOw (ORCPT ); Fri, 17 Jul 2015 08:14:52 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:38429 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757252AbbGQMOv (ORCPT ); Fri, 17 Jul 2015 08:14:51 -0400 Date: Fri, 17 Jul 2015 14:14:46 +0200 From: Ingo Molnar To: Borislav Petkov Cc: Laura Abbott , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Andy Lutomirski Subject: Re: [RFC][PATCH] x86, CPU: Restore MSR_IA32_ENERGY_PERF_BIAS after resume Message-ID: <20150717121446.GA11210@gmail.com> References: <1437084561-18679-1-git-send-email-labbott@fedoraproject.org> <20150717083953.GA27348@nazgul.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150717083953.GA27348@nazgul.tnic> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 29 * Borislav Petkov wrote: > > EXPORT_SYMBOL_GPL(__static_cpu_has_safe); > > + > > +static void cpu_custom_resume(void) > > Let's call this bsp_resume() as it is run only on the boot CPU. > > > +{ > > + if (this_cpu->c_resume) > > + this_cpu->c_resume(&boot_cpu_data); > > +} > > So giving boot_cpu_data means, this is the boot CPU but you're assigning it to > c_resume() which means, every CPU. What you could do is call the function ptr > ->c_bsp_resume like the ->c_bsp_init which we already have so that it is clear > that it is run only on the BSP. > > Rest looks ok to me, unless tip guys have a better idea... Looks good to me! Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/