Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758099AbbGQNep (ORCPT ); Fri, 17 Jul 2015 09:34:45 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:35580 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757373AbbGQNek (ORCPT ); Fri, 17 Jul 2015 09:34:40 -0400 Message-ID: <55A90467.9000804@hurleysoftware.com> Date: Fri, 17 Jul 2015 09:34:31 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joerg Roedel CC: Greg Kroah-Hartman , Jiri Slaby , Sebastian Andrzej Siewior , Tony Lindgren , Alan Cox , linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org, Joerg Roedel , Michael Welling , Joe Schultz Subject: Re: [PATCH] serial: 8250: Do XR17V35X specific wakeup in serial8250_do_startup References: <1437035353-13708-1-git-send-email-joro@8bytes.org> In-Reply-To: <1437035353-13708-1-git-send-email-joro@8bytes.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1976 Lines: 62 On 07/16/2015 04:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > The XR17V35X UART needs the ECB bit set in its XR_EFR > register to enable access to IER [7:5], ISR [5:4], FCR[5:4], > MCR[7:5], and MSR [7:0]. > > Also reset the IER register to mask interrupts after access > to all bits of this register has been enabled. > > This makes my 8-port XR17V35X working with the in-kernel > serial driver. Reviewed-by: Peter Hurley Also, would you please find out what bits are set in the IER that this fixes and let me know? I don't have this hardware. Regards, Peter Hurley > Cc: Peter Hurley > Cc: Michael Welling > Cc: Joe Schultz > Signed-off-by: Joerg Roedel > --- > drivers/tty/serial/8250/8250_core.c | 15 +++++++++++++++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c > index 37fff12..4124a91 100644 > --- a/drivers/tty/serial/8250/8250_core.c > +++ b/drivers/tty/serial/8250/8250_core.c > @@ -2164,6 +2164,21 @@ int serial8250_do_startup(struct uart_port *port) > */ > enable_rsa(up); > #endif > + > + if (port->type == PORT_XR17V35X) { > + /* > + * First enable access to IER [7:5], ISR [5:4], FCR [5:4], > + * MCR [7:5] and MSR [7:0] > + */ > + serial_port_out(port, UART_XR_EFR, UART_EFR_ECB); > + > + /* > + * Make sure all interrups are masked until initialization is > + * complete and the FIFOs are cleared > + */ > + serial_port_out(port, UART_IER, 0); > + } > + > /* > * Clear the FIFO buffers and disable them. > * (they will be reenabled in set_termios()) > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/