Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758192AbbGQNjM (ORCPT ); Fri, 17 Jul 2015 09:39:12 -0400 Received: from smtp02.citrix.com ([66.165.176.63]:20624 "EHLO SMTP02.CITRIX.COM" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756923AbbGQNjK (ORCPT ); Fri, 17 Jul 2015 09:39:10 -0400 X-IronPort-AV: E=Sophos;i="5.15,496,1432598400"; d="scan'208";a="285103971" Date: Fri, 17 Jul 2015 14:37:38 +0100 From: Stefano Stabellini X-X-Sender: sstabellini@kaball.uk.xensource.com To: Julien Grall CC: Stefano Stabellini , Russell King , , , David Vrabel , , Boris Ostrovsky , Subject: Re: [Xen-devel] [PATCH v2 14/20] xen/grant-table: Make it running on 64KB granularity In-Reply-To: <55A7DA8F.2040805@citrix.com> Message-ID: References: <1436474552-31789-1-git-send-email-julien.grall@citrix.com> <1436474552-31789-15-git-send-email-julien.grall@citrix.com> <55A7DA8F.2040805@citrix.com> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-DLP: MIA2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1062 Lines: 27 On Thu, 16 Jul 2015, Julien Grall wrote: > Hi Stefano, > > On 16/07/2015 16:47, Stefano Stabellini wrote: > >> diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c > > > index 3679293..0a1f903 100644 > > > --- a/drivers/xen/grant-table.c > > > +++ b/drivers/xen/grant-table.c > > > > The arm part is fine, but aren't you missing the change to RPP and SPP? > > SPP has been removed by commit 548f7c94759ac58d4744ef2663e2a66a106e21c5 as it > was unused. > > For RPP, it's used internally so there is no need to switch to XEN_PAGE_SIZE. > Otherwise we will waste 60KB for each internal page allocated (see > gnttab_init). I see now that RPP is specifically for internal data structures in grant-table.c and it is used consistently. Reviewed-by: Stefano Stabellini -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/