Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757277AbbGQOYs (ORCPT ); Fri, 17 Jul 2015 10:24:48 -0400 Received: from mga01.intel.com ([192.55.52.88]:52307 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752113AbbGQOYr convert rfc822-to-8bit (ORCPT ); Fri, 17 Jul 2015 10:24:47 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,496,1432623600"; d="scan'208";a="608099966" From: "Liang, Kan" To: Jiri Olsa CC: "acme@kernel.org" , "jolsa@kernel.org" , "namhyung@kernel.org" , "ak@linux.intel.com" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH RFC V4 1/4] perf,tools: introduce callgraph_set for callgraph option Thread-Topic: [PATCH RFC V4 1/4] perf,tools: introduce callgraph_set for callgraph option Thread-Index: AQHQv93HcrurJeYp30S86r6JTMzWQ53e3sWAgADZYFA= Date: Fri, 17 Jul 2015 14:24:30 +0000 Message-ID: <37D7C6CF3E00A74B8858931C1DB2F0770188DB27@SHSMSX103.ccr.corp.intel.com> References: <1437035170-12911-1-git-send-email-kan.liang@intel.com> <1437035170-12911-2-git-send-email-kan.liang@intel.com> <20150717092357.GA1057@krava.redhat.com> In-Reply-To: <20150717092357.GA1057@krava.redhat.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1258 Lines: 40 > > @@ -784,10 +785,11 @@ int record_parse_callchain_opt(const struct > option *opt __maybe_unused, > > return ret; > > } > > > > -int record_callchain_opt(const struct option *opt __maybe_unused, > > +int record_callchain_opt(const struct option *opt, > > const char *arg __maybe_unused, > > int unset __maybe_unused) > > { > > + *(bool *)opt->set = true; > > hum, how does this set callgraph_set ? > shouldn't it be 'callgraph_set = true' instead? > Right, I mixed the patch with the previous one. It should be as below. I will fix it in next version. Thanks, Kan @@ -789,7 +790,9 @@ int record_callchain_opt(const struct option *opt, const char *arg __maybe_unused, int unset __maybe_unused) { - *(bool *)opt->set = true; + struct record_opts *record = (struct record_opts *)opt->value; + + record->callgraph_set = true; callchain_param.enabled = true; if (callchain_param.record_mode == CALLCHAIN_NONE) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/