Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758162AbbGQPJw (ORCPT ); Fri, 17 Jul 2015 11:09:52 -0400 Received: from resqmta-ch2-11v.sys.comcast.net ([69.252.207.43]:40922 "EHLO resqmta-ch2-11v.sys.comcast.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751334AbbGQPJv (ORCPT ); Fri, 17 Jul 2015 11:09:51 -0400 Date: Fri, 17 Jul 2015 10:09:49 -0500 (CDT) From: Christoph Lameter X-X-Sender: cl@east.gentwo.org To: Konstantin Khlebnikov cc: Konstantin Khlebnikov , "linux-mm@kvack.org" , Andrew Morton , Linux Kernel Mailing List Subject: Re: [PATCH 2/2] mm/slub: disable merging after enabling debug in runtime In-Reply-To: Message-ID: References: <20150714131704.21442.17939.stgit@buzz> <20150714131705.21442.99279.stgit@buzz> Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1079 Lines: 28 On Fri, 17 Jul 2015, Konstantin Khlebnikov wrote: > > Hrm.... Bad. Maybe drop the checks for the debug options that can be > > configured when merging slabs? They do not influence the object layout > > per definition. > > I don't understand that. Debug options do changes in object layout. Only some debug options change the object layout and those are alrady forbidden for caches with objects. > Since they add significant performance overhead and cannot be undone in runtime > it's unlikely that anyone who uses them don't care about merging after that. Those that do not affect the object layout can be undone. > Also I don't see how merging could affect debugging in positive way > (except debugging bugs in merging logic itself). The problem here is that debugging is switched on for slabs that are already merged right? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/