Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758743AbbGQPh4 (ORCPT ); Fri, 17 Jul 2015 11:37:56 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:39714 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758537AbbGQPhy (ORCPT ); Fri, 17 Jul 2015 11:37:54 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-94-55a9214f3dd7 Message-id: <55A9214E.8060608@samsung.com> Date: Fri, 17 Jul 2015 17:37:50 +0200 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Linus Walleij Cc: "linux-leds@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Bryan Wu , Richard Purdie , Stas Sergeev , jacek.anaszewski@gmail.com Subject: Re: [PATCH/RFC 51/51] leds: ipaq-micro: Mark the LED fast References: <1437122857-6765-1-git-send-email-j.anaszewski@samsung.com> <1437122857-6765-52-git-send-email-j.anaszewski@samsung.com> In-reply-to: Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrLLMWRmVeSWpSXmKPExsVy+t/xa7r+iitDDabf1LY4unMik8XtrRtY LKb8Wc5kcXnXHDaLrW/WMVrs3vWU1aKzbxqLA7vHzll32T3uXNvD5rFn/g9Wj6ZT7awenzfJ BbBGcdmkpOZklqUW6dslcGV8m9TBXrCfpeLguuOsDYyXmLsYOTgkBEwkZh2S72LkBDLFJC7c W8/WxcjFISSwlFHi+ZotLBDOM0aJ+0suM4JU8QpoSfS9nsUMYrMIqEp0/5nKBmKzCRhK/Hzx mgnEFhWIkPhzeh8rRL2gxI/J91hAbBEBHYnubT9ZQYYyC/QwSfw6+AAsISzgJPF5dxMjxLaz jBKLZ6wFm8QpECyx6vBvsA3MAmYSj1rWMUPY8hKb17xlnsAoMAvJkllIymYhKVvAyLyKUTS1 NLmgOCk911CvODG3uDQvXS85P3cTIyTQv+xgXHzM6hCjAAejEg9vg+uKUCHWxLLiytxDjBIc zEoivEGyK0OFeFMSK6tSi/Lji0pzUosPMUpzsCiJ887d9T5ESCA9sSQ1OzW1ILUIJsvEwSnV wMgast2n6Ih3zD3n+xz9y24FO3oVJtfY/Xk1ec6GTVGS3F6JDx3v8nBMPfRuJ+uvrOB+I7u0 dT6zHDe1pqmuuGbC6dez8bzHpoid6hYWunMajs5pm/LU53ijcO3tWu0HDsrrVxQ9KFg49WFz huRfnqnmL8pyixfsu6e1Uzui55Gyi1evvqR2kxJLcUaioRZzUXEiAEEafdFwAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 800 Lines: 25 On 07/17/2015 03:43 PM, Linus Walleij wrote: > On Fri, Jul 17, 2015 at 10:47 AM, Jacek Anaszewski > wrote: > >> The driver neither sleeps nor uses delays in its brightness_set >> op. Mark it fast then. >> >> Signed-off-by: Jacek Anaszewski >> Cc: Linus Walleij > > NACK. The functions called in drivers/mfd/ipaq-micro.c are > not fast, this need to be dropped. Oops, indeed I missed that it waits for completion. Thanks for the review. -- Best Regards, Jacek Anaszewski -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/