Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751964AbbGQP5g (ORCPT ); Fri, 17 Jul 2015 11:57:36 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:34296 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750699AbbGQP5e (ORCPT ); Fri, 17 Jul 2015 11:57:34 -0400 From: Andrew Vagin X-Google-Original-From: Andrew Vagin Date: Fri, 17 Jul 2015 18:57:29 +0300 To: Oleg Nesterov Cc: Andrey Vagin , linux-kernel@vger.kernel.org, linux-api@vger.kernel.org, Andrew Morton , Cyrill Gorcunov , Pavel Emelyanov , Roger Luethi , Arnd Bergmann , Arnaldo Carvalho de Melo , David Ahern , Andy Lutomirski , Pavel Odintsov Subject: Re: [PATCH 08/24] proc: pick out a function to iterate task children Message-ID: <20150717155728.GB6685@odin.com> References: <1436172445-6979-1-git-send-email-avagin@openvz.org> <1436172445-6979-9-git-send-email-avagin@openvz.org> <20150714180235.GB8088@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <20150714180235.GB8088@redhat.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1170 Lines: 32 On Tue, Jul 14, 2015 at 08:02:35PM +0200, Oleg Nesterov wrote: > On 07/06, Andrey Vagin wrote: > > > > -static struct pid * > > -get_children_pid(struct inode *inode, struct pid *pid_prev, loff_t pos) > > +static struct task_struct * > > +task_next_child(struct task_struct *parent, struct task_struct *prev, unsigned int pos) > > { > > I won't really argue, just a question... > > So this patch changes it to accept/return task_struct rather pid. Why? > it is better to get/put "struct pid" only, not the whole task_struct. > > If another caller want task_struct, the necessary conversion is simple. Another caller wants task_struct. Currently this function receives pid and converts it into task_struct, then gets the next child and returns its pid. So I try to avoid extra conversion in task_diag code. > But again, I won't argue if you think this will complicate the non-proc > users of this helper. > > Oleg. > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/