Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754967AbbGQRPt (ORCPT ); Fri, 17 Jul 2015 13:15:49 -0400 Received: from foss.arm.com ([217.140.101.70]:50056 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754101AbbGQRPs (ORCPT ); Fri, 17 Jul 2015 13:15:48 -0400 Date: Fri, 17 Jul 2015 18:15:22 +0100 From: Mark Rutland To: David Daney Cc: Lorenzo Pieralisi , Jason Cooper , David Daney , Catalin Marinas , Will Deacon , "linux-kernel@vger.kernel.org" , Robert Richter , David Daney , "linux-pci@vger.kernel.org" , Bjorn Helgaas , Thomas Gleixner , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH 3/5] arm64, pci: Allow RC drivers to supply pcibios_add_device() implementation. Message-ID: <20150717171522.GI26091@leverpostej> References: <1436979285-8177-1-git-send-email-ddaney.cavm@gmail.com> <1436979285-8177-4-git-send-email-ddaney.cavm@gmail.com> <20150716090426.GA17097@red-moon> <55A7E334.3030101@caviumnetworks.com> <20150717110016.GB19067@red-moon> <55A92F95.307@caviumnetworks.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55A92F95.307@caviumnetworks.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2811 Lines: 89 On Fri, Jul 17, 2015 at 05:38:45PM +0100, David Daney wrote: > On 07/17/2015 04:00 AM, Lorenzo Pieralisi wrote: > > Hi David, > > > > On Thu, Jul 16, 2015 at 06:00:36PM +0100, David Daney wrote: > >> On 07/16/2015 02:04 AM, Lorenzo Pieralisi wrote: > >>> Hi David, > >>> > >>> On Wed, Jul 15, 2015 at 05:54:43PM +0100, David Daney wrote: > >>>> From: David Daney > >>>> > >> [...] > >>>> diff --git a/arch/arm64/kernel/pci.c b/arch/arm64/kernel/pci.c > >>>> index 4095379..3356023 100644 > >>>> --- a/arch/arm64/kernel/pci.c > >>>> +++ b/arch/arm64/kernel/pci.c > >>>> @@ -38,11 +38,21 @@ resource_size_t pcibios_align_resource(void *data, const struct resource *res, > >>>> return res->start; > >>>> } > >>>> > >>>> +static int (*pcibios_add_device_impl)(struct pci_dev *); > >>>> + > >>>> +void set_pcibios_add_device(int (*arg)(struct pci_dev *)) > >>>> +{ > >>>> + pcibios_add_device_impl = arg; > >>>> +} > >>>> + > >>>> /* > >>>> * Try to assign the IRQ number from DT when adding a new device > >>>> */ > >>>> int pcibios_add_device(struct pci_dev *dev) > >>>> { > >>>> + if (pcibios_add_device_impl) > >>>> + return pcibios_add_device_impl(dev); > >>> > >>> I am totally against this (and to be honest by reading the other > >>> patches I failed to understand why you even need it), see above. > >>> > >> > >> It is because ... > >> > >> > >>> Thanks, > >>> Lorenzo > >>> > >>>> + > >>>> dev->irq = of_irq_parse_and_map_pci(dev, 0, 0); > >> > >> > >> ... this is total crap. But I didn't want to break existing systems. > > > > That's a good aim, but you are still failing to explain the issue properly > > I am afraid. > > > >> The PCI RC drivers need a way to configure the legacy virtual-wire > >> interrupts, because the existing code doesn't do it. > > > > Can I ask you please to explain the issue a bit more clearly (and why > > the OF API does not work for you ?) > > Several problems: > > 1) It prints many times to the boot log this string: > pci 0000:01:0e.2: of_irq_parse_pci() failed with rc=-19 which happens because...? That's -ENODEV. As far as I can tell, that only gets printed if the device doesn't have a wired interrupt (the interrupt pin field in config space read as zero). So that's beningn, but annoying? Surely we can clean that up. > 2) For a RC with no device_node it does nothing (in addition to printing > the annoying message). Your root complex has a device_node if it is described in DT. Is the problem that this doesn't work with ACPI? Thanks, Mark. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/