From: Paul Moore <pmoore@redhat.com>
To: Richard Guy Briggs <rgb@redhat.com>
Cc: Eric Paris <eparis@redhat.com>, linux-audit@redhat.com,
        linux-kernel@vger.kernel.org, sgrubb@redhat.com
Subject: Re: [PATCH V6 4/4] audit: avoid double copying the audit_exe path string
Date: Fri, 17 Jul 2015 14:01:47 -0400
Message-ID: <2210388.jZFblZFq4z@sifl>
Organization: Red Hat
User-Agent: KMail/4.14.10 (Linux/4.1.2-gentoo; KDE/4.14.10; x86_64; ; )
In-Reply-To: <20150717161827.GA20540@madcap2.tricolour.ca>
References: <cover.1436823321.git.rgb@redhat.com> <1437102090.18955.93.camel@redhat.com> <20150717161827.GA20540@madcap2.tricolour.ca>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1083
Lines: 27

On Friday, July 17, 2015 12:18:27 PM Richard Guy Briggs wrote:
> On 15/07/16, Eric Paris wrote:
> > I have to admit, I'm partial to not merging this (with the other
> > patches).  Changing object lifetimes in what i seem to remember is long
> > standing code (auditfilter, not auditexe) seems to me like something we
> > really would want to be git bisectable, not mushed with an unrelated
> > feature addition. But it ain't my tree   :)
> 
> So maybe even fixing this before applying the audit exe stuff has
> merit...

No, let's get the exe filter stuff in now just so I can get all you guys off 
my back about it :)

The refcnt stuff is almost surely going to get messy and I would just assume 
not deal with that right now since it appears to be working.  We have other 
stuff we need to fix first.

-- 
paul moore
security @ redhat

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/