Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756036AbbGQSLf (ORCPT ); Fri, 17 Jul 2015 14:11:35 -0400 Received: from mezzanine.sirena.org.uk ([106.187.55.193]:55952 "EHLO mezzanine.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753004AbbGQSLd (ORCPT ); Fri, 17 Jul 2015 14:11:33 -0400 Date: Fri, 17 Jul 2015 19:11:22 +0100 From: Mark Brown To: Xing Zheng Cc: dgreid@chromium.org, dianders@chromium.org, heiko@sntech.de, sonnyrao@chromium.org, linux-rockchip@lists.infradead.org, Liam Girdwood , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-kernel@lists.infradead.org Message-ID: <20150717181122.GT11162@sirena.org.uk> References: <1436930143-31361-1-git-send-email-zhengxing@rock-chips.com> <1436930143-31361-3-git-send-email-zhengxing@rock-chips.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="s2l28wc1uYKejhFF" Content-Disposition: inline In-Reply-To: <1436930143-31361-3-git-send-email-zhengxing@rock-chips.com> X-Cookie: Stay together, drag each other down. User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: 94.175.94.161 X-SA-Exim-Mail-From: broonie@sirena.org.uk Subject: Re: [PATCH 2/2] ASoC: rockchip: Add machine driver for rt5645/rt5650 codec X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: Yes (on mezzanine.sirena.org.uk) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1317 Lines: 36 --s2l28wc1uYKejhFF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 15, 2015 at 11:15:43AM +0800, Xing Zheng wrote: > From: zhengxing >=20 > The driver is used for rockchip board using a rt5645/rt5650. Same comments here, mostly good but some minor issues. The other thing with both of these is that you need to have a binding document for them. --s2l28wc1uYKejhFF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVqUVJAAoJECTWi3JdVIfQmToH/R5aRbWmamydxxUNcX3uSyFK HHtkh+slbdVAA3dbMEFzHyxa4yoc2GcRpqQPgUyGWJZG3eFvb79czvcCoDd2zZdc oKi0pxmXu8l+mEVXLR5alACcKPP5cck2Lmf3zQHQ99QGQl5n5d+0UQlJQRI1SBmX Uyqj4y4uQnC/feGx61z5dLDdARsG/vva3m/EhMY5Oqk0iksLxISfkXRkh5JYMpvd 7RuYimg5uGpPj/oR99o3YueJXtJb4HhflaZoel5U7rXw00xiowW089Pk/zYYew+8 FCGAjEknqnx5pfKwDUxo5FJL4ZJwTGsdT477yZb7iSS8w+h0iEBAPOBvjXGWaVE= =NuOw -----END PGP SIGNATURE----- --s2l28wc1uYKejhFF-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/