Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756057AbbGQSM3 (ORCPT ); Fri, 17 Jul 2015 14:12:29 -0400 Received: from mail-ig0-f177.google.com ([209.85.213.177]:34169 "EHLO mail-ig0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754276AbbGQSM2 (ORCPT ); Fri, 17 Jul 2015 14:12:28 -0400 Message-ID: <55A94578.5050306@gmail.com> Date: Fri, 17 Jul 2015 14:12:08 -0400 From: Austin S Hemmelgarn User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Oleg Nesterov , Benjamin LaHaise CC: Andrew Morton , Joonsoo Kim , Fengguang Wu , Jeff Moyer , Johannes Weiner , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm-move-mremap-from-file_operations-to-vm_operations_struct-fix References: <20150716231405.GA25147@redhat.com> <20150716162444.26425f5e227387f1166a6d16@linux-foundation.org> <20150716235227.GA26551@redhat.com> <20150717140615.GA2779@kvack.org> <20150717172726.GA30443@redhat.com> <20150717173757.GD2779@kvack.org> <20150717175542.GA31888@redhat.com> In-Reply-To: <20150717175542.GA31888@redhat.com> x-hashcash: 1:21:150717:oleg@redhat.com::a7aad7e12efe332f1d003e8119271e99:42fb34b0b1008760 x-hashcash: 1:21:150717:bcrl@kvack.org::4db7b1cb6cdbc00e55ff47e09ec8c414:947a726b30180ed7 x-hashcash: 1:21:150717:akpm@linux-foundation.org::7c8c5db35a1027a09536e31120efd9f5:3c10ae2002b44d17 x-hashcash: 1:21:150717:js1304@gmail.com::f77629a7b551d41234eff40510952e18:4c66df5d479e6311 x-hashcash: 1:21:150717:fengguang.wu@intel.com::c77f78543b0698b0d790d48f9f9254cf:d901fa8652e7cd3a x-hashcash: 1:21:150717:jmoyer@redhat.com::e3e6fc725a07d534d6164cd6b3e63980:67b2c1d5852467a2 x-hashcash: 1:21:150717:hannes@cmpxchg.org::aa857db6908422b7fde7844e9b618298:b2b06bb8ffb3a216 x-hashcash: 1:21:150717:sfr@canb.auug.org.au::fea595c1a093fc8dabaabecb6903f1a4:50aa9d4f96e34eb8 x-hashcash: 1:21:150717:linux-next@vger.kernel.org::907f165ec1a8c9b3d185a3c83429b5e:9c6b4f6e41e19a16 x-hashcash: 1:21:150717:linux-kernel@vger.kernel.org::8215ef337f48213a1c3493d10b8990e9:54301c3dcfae7a5f x-stampprotocols: hashcash:1:17;mbound:0:10:3000:5000 Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha1; boundary="------------ms010900080701070409030005" X-Antivirus: avast! (VPS 150717-0, 2015-07-17), Outbound message X-Antivirus-Status: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5318 Lines: 92 This is a cryptographically signed message in MIME format. --------------ms010900080701070409030005 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: quoted-printable On 2015-07-17 13:55, Oleg Nesterov wrote: > On 07/17, Benjamin LaHaise wrote: >> >> Don't add BUG(). It's the equivalent approach of saying "I think this= code >> isn't needed, but I'm lazy and not going to remove it properly." > > There is another interpretation: I think this code must be never called= , > if it is actually called we have a serious problem which should be loud= ly > reported. > And not compiling it at all _will_ loudly report it, it'll just report=20 it during linking instead of at run-time, which is a much better time to = shout about it. --------------ms010900080701070409030005 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIAGCSqGSIb3DQEHAqCAMIACAQExCzAJBgUrDgMCGgUAMIAGCSqGSIb3DQEHAQAAoIIGuDCC BrQwggScoAMCAQICAxBuVTANBgkqhkiG9w0BAQ0FADB5MRAwDgYDVQQKEwdSb290IENBMR4w HAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmlu ZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZzAeFw0xNTAz MjUxOTM0MzhaFw0xNTA5MjExOTM0MzhaMGMxGDAWBgNVBAMTD0NBY2VydCBXb1QgVXNlcjEj MCEGCSqGSIb3DQEJARYUYWhmZXJyb2luN0BnbWFpbC5jb20xIjAgBgkqhkiG9w0BCQEWE2Fo ZW1tZWxnQG9oaW9ndC5jb20wggIiMA0GCSqGSIb3DQEBAQUAA4ICDwAwggIKAoICAQCdD/zW 2rRAFCLnDfXpWxU1+ODqRVUgzHvrRO7ADUxRo1CBDc3JSX5TIW2OGmQ3DAKGOACp8Z0sgxMc B05tzAZ/M7m4jajVrwwdVCdrwVGxTdAai7Kwg4ZCVfyMVhcwo8R2eW3QahBx34G0RKumK9sZ ZQSQ+zULAzpY6uz7T1sAk/erMoivRXF6u8WvOsLkOD1F/Xyv1ZccSUG5YeDgZgc0nZUBvyIp zXSHjgWerFkrxEM3y2z/Ff3eL1sgGYecV/I1F+I5S01V7Kclt/qRW10c/4JEGRcI1FmrJBPu BtMYPbg/3Y9LZROYN+mVIFxZxOfrmjfFZ96xt/TaMXo8vcEKtWcNEjhGBjEbfMUEm4aq8ygQ 4MuEcpJc8DJCHBkg2KBk13DkbU2qNepTD6Uip1C+g+KMr0nd6KOJqSH27ZuNY4xqV4hIxFHp ex0zY7mq6fV2o6sKBGQzRdI20FDYmNjsLJwjH6qJ8laxFphZnPRpBThmu0AjuBWE72GnI1oA aO+bs92MQGJernt7hByCnDO82W/ykbVz+Ge3Sax8NY0m2Xdvp6WFDY/PjD9CdaJ9nwQGsUSa N54lrZ2qMTeCI9Vauwf6U69BA42xgk65VvxvTNqji+tZ4aZbarZ7el2/QDHOb/rRwlCFplS/ z4l1f1nOrE6bnDl5RBJyW3zi74P6GwIDAQABo4IBWTCCAVUwDAYDVR0TAQH/BAIwADBWBglg hkgBhvhCAQ0ESRZHVG8gZ2V0IHlvdXIgb3duIGNlcnRpZmljYXRlIGZvciBGUkVFIGhlYWQg b3ZlciB0byBodHRwOi8vd3d3LkNBY2VydC5vcmcwDgYDVR0PAQH/BAQDAgOoMEAGA1UdJQQ5 MDcGCCsGAQUFBwMEBggrBgEFBQcDAgYKKwYBBAGCNwoDBAYKKwYBBAGCNwoDAwYJYIZIAYb4 QgQBMDIGCCsGAQUFBwEBBCYwJDAiBggrBgEFBQcwAYYWaHR0cDovL29jc3AuY2FjZXJ0Lm9y ZzAxBgNVHR8EKjAoMCagJKAihiBodHRwOi8vY3JsLmNhY2VydC5vcmcvcmV2b2tlLmNybDA0 BgNVHREELTArgRRhaGZlcnJvaW43QGdtYWlsLmNvbYETYWhlbW1lbGdAb2hpb2d0LmNvbTAN BgkqhkiG9w0BAQ0FAAOCAgEAGvl7xb42JMRH5D/vCIDYvFY3dR2FPd5kmOqpKU/fvQ8ovmJa p5N/FDrsCL+YdslxPY+AAn78PYmL5pFHTdRadT++07DPIMtQyy2qd+XRmz6zP8Il7vGcEDmO WmMLYMq4xV9s/N7t7JJp6ftdIYUcoTVChUgilDaRWMLidtslCdRsBVfUjPb1bF5Ua31diKDP e0M9/e2CU36rbcTtiNCXhptMigzuL3zJXUf2B9jyUV8pnqNEQH36fqJ7YTBLcpq3aYa2XbAH Hgx9GehJBIqwspDmhPCFZ/QmqUXCkt+XfvinQ2NzKR6P3+OdYbwqzVX8BdMeojh7Ig8x/nIx mQ+/ufstL1ZYp0bg13fyK/hPYSIBpayaC76vzWovkIm70DIDRIFLi20p/qTd7rfDYy831Hjm +lDdCECF9bIXEWFk33kA97dgQIMbf5chEmlFg8S0e4iw7LMjvRqMX3eCD8GJ2+oqyZUwzZxy S0Mx+rBld5rrN7LsXwZ671HsGqNeYbYeU25e7t7/Gcc6Bd/kPfA+adEuUGFcvUKH3trDYqNq 6mOkAd8WO/mQadlc3ztS++XDMhmIpfBre9MPAr6usqf+wc+R8Nk9KLK39kEgrqVfzc/fgf8L MaD4rHnusdg4gca6Yi+kNrm99anw7SwaBrBvULYBp7ixNRUhaYiNW4YjTrYxggShMIIEnQIB ATCBgDB5MRAwDgYDVQQKEwdSb290IENBMR4wHAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5v cmcxIjAgBgNVBAMTGUNBIENlcnQgU2lnbmluZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEW EnN1cHBvcnRAY2FjZXJ0Lm9yZwIDEG5VMAkGBSsOAwIaBQCgggH1MBgGCSqGSIb3DQEJAzEL BgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkFMQ8XDTE1MDcxNzE4MTIwOFowIwYJKoZIhvcNAQkE MRYEFBe3y/L2sxOVATJsYTfATw/8b5rNMGwGCSqGSIb3DQEJDzFfMF0wCwYJYIZIAWUDBAEq MAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzAOBggqhkiG9w0DAgICAIAwDQYIKoZIhvcNAwIC AUAwBwYFKw4DAgcwDQYIKoZIhvcNAwICASgwgZEGCSsGAQQBgjcQBDGBgzCBgDB5MRAwDgYD VQQKEwdSb290IENBMR4wHAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMT GUNBIENlcnQgU2lnbmluZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2Fj ZXJ0Lm9yZwIDEG5VMIGTBgsqhkiG9w0BCRACCzGBg6CBgDB5MRAwDgYDVQQKEwdSb290IENB MR4wHAYDVQQLExVodHRwOi8vd3d3LmNhY2VydC5vcmcxIjAgBgNVBAMTGUNBIENlcnQgU2ln bmluZyBBdXRob3JpdHkxITAfBgkqhkiG9w0BCQEWEnN1cHBvcnRAY2FjZXJ0Lm9yZwIDEG5V MA0GCSqGSIb3DQEBAQUABIICADvQGEds140g4x1CZKKh/6P1xPCrT9dE2uKzd/5f4ToEoMTp 3ryIRZyHHf7rpaQszBy7kn7Y81XfoIB9Xg33rDTJlZpHa0nPZ6Rk3bHuLWGbVYKcZYHYZFT3 bxl2JaDsowsrnd0KCO1+tNkiaN74ok5GU0dUsEstrUOijOuGg5dzH1hZUjod5qx/FGdF3x0s eySGr7/XL8jZ5cCkj+xWyXQTu1iRjmAe7xOeJFm48UNLc157EFPoHocsA/L6GRWRWTm2q0HJ PjxkNCvrocb6Kk14ZVebU8kFiTDqKJcO2BJw8zWWMcA7iSh06ZE/Qjy4aNPTBRYe/26xLuJr mEkwT/HcnQEL6X0mp/LbQjzj8RQcbzXAL7pRWn9FlfFCclfQQ0DbATtxB11k6a8G1q/vPAp8 7PV6cdX2MUW2CE6z8fOBbVhCpnz57NGNqkDURwJP0soU3Crxt59Xog3Y7lj44Nq6B73SaFTU 5J6yhcAod0ifwN/4cASo53pmaTlmI7VzuIQK1juHYRASYnqpFlBAt5eYBY6E6Y17ruZmsKF0 KHgtulA+8j/8EkAPQ2jaSqaTYdKfrfHkSigPDDiXrFEcfMhM4s3cM576/F0j19PxYETmibeS YHIRRxaVCCj+JumeVCyW7sovzLVT3WNC0xm0xkUr5jynt67Bbh0JZpP3dPD1AAAAAAAA --------------ms010900080701070409030005-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/