Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752269AbbGQS3x (ORCPT ); Fri, 17 Jul 2015 14:29:53 -0400 Received: from mail-by2on0078.outbound.protection.outlook.com ([207.46.100.78]:29536 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751587AbbGQS3u (ORCPT ); Fri, 17 Jul 2015 14:29:50 -0400 Authentication-Results: spf=fail (sender IP is 66.35.236.236) smtp.mailfrom=opensource.altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none; Authentication-Results: infradead.org; dkim=none (message not signed) header.d=none; Date: Fri, 17 Jul 2015 13:25:03 -0500 From: atull X-X-Sender: atull@linuxheads99 To: Randy Dunlap CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Petr Cvek , , Subject: Re: [PATCH v9 5/7] staging: fpga manager core In-Reply-To: <55A93B01.4080009@infradead.org> Message-ID: References: <1437148277-5405-1-git-send-email-atull@opensource.altera.com> <1437148277-5405-6-git-send-email-atull@opensource.altera.com> <55A93B01.4080009@infradead.org> User-Agent: Alpine 2.02 (DEB 1266 2009-07-14) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" X-Originating-IP: [64.129.157.38] X-ClientProxiedBy: BLUPR05CA0047.namprd05.prod.outlook.com (10.141.20.17) To BN3PR03MB1512.namprd03.prod.outlook.com (25.163.35.150) X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1512;2:4pIcsROtMJ3yHvrwgmG9sRdteQ7H0UCxe0wcyAF2gkFT9WBbqVF7iAv7OGqvk46N;3:Y5taKd9tVpk1G+MCjg/y1F1lfhZV8VkUy1VusrOLN2YkT9gUEqLKZHlNHPDn+qBPoeaC1DLlCmR8oiniQUSDn8TnchMOWPxM23KSO1EvrlaxR4aLeCKwyULqw/KFsFnps972fSeWZ+rMZKCbazUHUg==;25:6NC+XcUK8HWM0ULsxRgX7pAViSukq2ZWxkAJ4uiAtz88UHfJRG2v2zQRQcoqgDJ4nWNM3LLfVgMIhLg414CgfMa81Wq51Rmdnbhg2jl6tmV0L+5fDtNsoCMqbp26h1ylovUJVsy3ZVq58KD9U1TUk6+I+492NTH9duVPIBdW75mkw9n3mr8Q6jYS3/96lUGpDIbAo5FagL/P+0PIFiSxgT3mTks6mIvvOFqk0fLO6K7oe26I6v+yudfTaownY1AZQzKwZLNJwUTIsDnKXq/nHQ==;20:Xsx/2HcqdtpbeeC3S8TieVk/c+qHIQSI1rFiGjS7io+3zYvyQn1kvYWYeMp99i0I8645tIs6ZP2Y7W82LOE7VnT1EUsUqBj6JgSf63f6Wd32cZ/iGtxLU7P5TPzmLSBAd3VDoOvcwkr+3sVAqsiDz2dwpOfv16BRfEoEV9cCEMA= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1512;UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB121; BN3PR03MB1512: X-MS-Exchange-Organization-RulesExecuted X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:;UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN3PR03MB1512;BCL:0;PCL:0;RULEID:;SRVR:BN3PR03MB1512;BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:BN1PR03MB121;BCL:0;PCL:0;RULEID:;SRVR:BN1PR03MB121; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1512;4:0FQ1f/IZqP2EeBWm81U75Rn6HpLDIT8BudK4EjgHRXJroRMIyqFl6tnx2hCPJFdcUH6ob4h64VV379Lgx/8/Cl+EZ4CG4887iM+/jKMT1Hg5QeGj8v2iRUaq9oI5yQmvLyHQ2RM7ahbqpN4pUgBlsFNSeYNpj4VynYdGFmgxHjKfMAGrYDmhZ8fHnsGdxs/nvj2G6cnGl7Ybnzq6gisXVack3Aq50BpT8eY0jFRdCQi4DoegZZqSqaQut8GIGP4rwOQu7yud9iyNB1B80MVE+kFbgJCDHWfc6tLFtu+26hE= X-Forefront-PRVS: 06400060E1 X-Forefront-Antispam-Report-Untrusted: SFV:NSPM;SFS:(10009020)(6009001)(164054003)(24454002)(479174004)(47776003)(4001350100001)(76176999)(50466002)(2950100001)(42186005)(46102003)(53416004)(54356999)(50986999)(110136002)(83506001)(189998001)(5001960100002)(92566002)(19580405001)(46406003)(87976001)(19580395003)(77096005)(77156002)(62966003)(86362001)(23726002)(122386002)(33716001)(86152002)(107886002)(7059030)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN3PR03MB1512;H:linuxheads99.altera.com;FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1512;23:3qxce8uEFVXEAJbsOW5WsCA/aKVamtgsmrQRSV/Mi2QueDhDm+yxBSTxRv4yCuWHK/xKw4JMogFa7BeHA48XN3tNHGgwiz8nrcpdVzVtShM+UI6G6/vVFKMChrwwHju3FhIGPRR7+N/dHkLWGWD+/uJF8CcBji5dwtv9j9ua/X1I5427s+0FHH1vIKBsd75/8jJM+UVqqhRwwY5eaVUyyKIXlyBWV4qDLBxKgKFVYeSjILKTv3lgK8/anaTyrDHOwgJgsZ+FfAIgpZJXQYNrySUVdw+CO9rUhTi7/RbuJ4i5Iz+styugyFIUxqA4CrEUyT7PNXxruJaS1FOWiUCyQMXbI3hfBSNobqwVS0/1ZuPf9W1VuKPTBHFRt+9P+kuxsx+Vv2ef/C0icqqLDAMwX07771kpJ93xfTjhLAoNCSPBEJI1YCoGuZkEY+NtfsfKbd9sc/JA2haNu+c39N3JgdkWZ1HBodEUp6xmDkyfloBmMVWvN9qOj7Il2MCzrgEgvIhMgHbubWWmP6yL5zKwG0uglu5Fu9HBO86nH5D3CFlieN5mkjXVnmatpYGR0d9EYqGpIvMUOSaal0FdXAkHOza+hFvDnxAnHvR6QkdqfmLna+kg6trcaHNe432qgbgFSK3AMWGE55978+36Gw5GUFiR77Kh99Xwj80otngSdgOYRaEQeEN8Nx59qK8tut9GzfYCdK3/kM7NXcShmcuIlKD8qD9NRRBUnzOEvRRoUvW8Zxm3KmblaUacScfx6X25N5GMwtYwGUNnjOOG96PX6IFKPuqe/NvG3zMss/T38JLbT7Oi96Pj/9ozXxUhQ+ssVK5OfPFxhExz1I8kwnP2jL11axP/MpZJwGK++nNUnaHyGZoifrK96ZyzZX/epWSxfapG0/vbbCw1wQ1XaTVk/5LqYUgpjUFw4ngthZ+bMN0= X-Microsoft-Exchange-Diagnostics-untrusted: 1;BN3PR03MB1512;5:oq+vH8EXLrLpXwBd/rd0PT0Ej04ZTkIlz+8mOw0pX/tTXYiKlLSHkRcnXg3pxutlbZhCRucrt+clTzuOwL73LUnvCucTWSlGrhSfrk5Ukly9ZFvJFH2VUQC0WqE/Dr+U2KcglA8mkpc0dASdSRKg7g==;24:teXzXOUsHV5sG0TQXidCYOrIc6hCCuiB4KBk7XebVeoWjrLZmprSZ9auiSqqgaCEWh/Q4zSJu7XGaZ6gS0vo3UkdSnz2N77rfNk42W8cqG4=;20:58oMtB/bGllzCxoFxdeqUPVaulGrnjkzlsR8yD1O0WikxVVHJMcsEa0BBANWMqWF/6ZVzKezgM/r0757sm/1qf9QvnKr34R3kpb7jZjPH0tgNQVfKQLv+XsY7qv9Qm9+ug1Fy5mZmvUhhCTJ3GzLk0F8trKq9ewvdzXC2bjurY8= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN3PR03MB1512 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: BN1BFFO11FD033.protection.gbl X-Microsoft-Exchange-Diagnostics: 1;BN1BFFO11FD033;1:ODp4BGJpnmaOp5/WpPfBuX9qhePoC1+zeXZEHsV4B3vPVNC+OfQeZlwCtJP4UfGXBh/oMSG54BfV35aLq/vt+tT7wSUAtQ4VooxIqVBI0y+99I6TQ2WJIgVeNfsoZCLeRnlXvHHCSdeAvMHMy4t9MVFTuygNQoyCcAI2e4UNzAa01vjg/ZMcaT4/1E+kGM0Zw4IGf0T02t3InOI0hCG/9T5OOhnIiNdlGRf32LpnIOp+MoDp9HUKHt/VcTynHbNjm5th5fOyvDm8se+teMSNsZad/53ic+7DBsXnShJ7ZFMXLloQ0xwzvRMkzD656wPG7KjRIktq+VPL0BSCsouS8u9mAdmFSxdnSq0dguDgNpYRFhVIEGcMP1jXBqiQuW1L7YZAd97gQc4KD4tjIaDigETlgP9vf7HV0XbH3jopQ/AcXZVwGesVN4jiPzj80XU/ X-Forefront-Antispam-Report: CIP:66.35.236.236;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(2980300002)(339900001)(189002)(199003)(24454002)(164054003)(479174004)(86362001)(47776003)(85426001)(46102003)(46406003)(92566002)(76176999)(54356999)(53416004)(19580405001)(83506001)(19580395003)(6806004)(4001350100001)(106466001)(33716001)(122386002)(87936001)(16796002)(62966003)(50466002)(50986999)(23726002)(2950100001)(105606002)(189998001)(110136002)(77156002)(86152002)(77096005)(5001960100002)(107886002)(7099028)(7059030)(4001430100001);DIR:OUT;SFP:1101;SCL:1;SRVR:BN1PR03MB121;H:sj-itexedge04.altera.priv.altera.com;FPR:;SPF:Fail;MLV:sfv;MX:1;A:0;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB121;2:dQD+b6S4SfmFNGK5Jp8wCWFCHm+Yz6iflQAxKOnD6TV89BTeY+2QOEgkL6SH5/LC;3:kcKxPUcLTIxAttbTOIhBQ9c5e5rg/19KMsJ3ib17jsUOqhI0sz49dBtfzHeyakka2USthPuQX6aqnu6tYFQMp5v3s+BNglesMXmp5DbRczRuU7Txj0DUsFmHBgcsxI0mQlte4KUDSkkk2WyAqr8uzauBk6tPU3FxcYEtcvU/jkQJGyNlumamxLa0WsacT/uhTJOztSc/yMSHPUzzwb9uQBzRjPtjO4QV3pNIjEiHvEI=;25:NcCpnCLxDED03r/xHKnP6Rma7KtXEa131CWkrAwhVdwppvWh30g9NiQw2IGazaSwOcNKITOzDyXSUfGfRXTxi4ehA77cRcrfHlZ0aou1iNv8R532bNFQummYguJDrcc+IaLzpibLnQUZGxbBiAH8dKhk6fRcKstVLfwx1yeHlhOjxpoND8OyUt+2H/1fx4D1QiTymcVyzPL3gvMyltaZjplH6sO5Ya+L+oyQ1Aa7r2iNy4Gtcvk+iciSG14wyug+P4mWM0xgG7WRJTgjmBdlUA==;20:yB6veFSEYg6Zqrw25A4cmnEqtR6y6ittb9QjLyOKGTrNuSGpwC65oqucOuMh2Kio7+DQvOmlShg7A8NRMcJv7VOw5ch20Oa1fpdQG1mIkHnPGQeaHseS1FWOvMns2duvxsVtqMhC9Qljf6fC1Nc0wNsWQ+EJQ/YeKAbGKrqydcg= X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB121;4:BOvZTXCRJG27VP1BHomx+1XILxcQ3XIfIgP6TG8gDZV2THgzVT2t783wPewfj4gdwd9i9vCm+1+UBHMUs3Tjgc2/t8mdsGFMAcUwMbOjbMOMhKaD8WrLIawds32ij0SE5p3r3ZLAOwdzbJe0kk6/nO8D61+mjQXut08eE13rFtaCZkor2cCTNUvm+4gxHgpyLkaENXGqSg6soSxmnllk1PHC1JJbvazUdo+b+wBqm67HrlTu9ylsm0MoF5gBpRMwOfhJ3fmh5MZOQBBZijWA4pKvhqT6V7bfYYAK4Xo0OOg= X-Forefront-PRVS: 06400060E1 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;BN1PR03MB121;23:CcDPTqyGOlO0yTTrMqUvY77r23XywdORHAdJGVtJwV?= =?us-ascii?Q?Eigo6VTqE29mYcc3FaqTU8fJpEINUtbEwsUYQPJfTiob+dZz1EnObyOeKUyO?= =?us-ascii?Q?s6Xir0jghCGLN43XnrUW8hLmazafTqgeZfE1FkZMQaoyv+KqMHG0YLrGG9Dc?= =?us-ascii?Q?JTn1dUPUUEOjyyH5Hvk/gE0F9qCFG2THhSRmJR0XI85bpz1Esj5CQldVPmHb?= =?us-ascii?Q?kmKguJBDTIptrg9ggVNIwBRONpL3QVTspM36lNpf0KFzpCWvIxcH+WUykwjR?= =?us-ascii?Q?VvsT/r+8PZ2BfhNZVH433dbu9dwtQqUsFwIR2AqvAvJGjs0Mm046ibm9k1e0?= =?us-ascii?Q?T8UJ8eelWukxsPnznU+QvvUJbCd3Z5Zi59CYz3WrmCGvZOXkFCgLBbZmlGJk?= =?us-ascii?Q?dsRngZ+MKbBGEQBdDCQxnAihBfevzeOOeCglu3oSKocj4Nk7IYuaX6aWS1Nw?= =?us-ascii?Q?DP2pQ9D/xugMZT+ziyJAooMiGsdtX4E8MqgwOZupBzBqWzlC09afr4ubMEwx?= =?us-ascii?Q?4QH8IZDdHmjnT/oR6PIJwB+o8+I8D2dERTNFMNnLvRRNVHM7WtJ0Nk2rId2+?= =?us-ascii?Q?TegbKcPqkVST8g+lmXFEHD+5RyGyyEnnLF33Al0qyiTdcpi0j7ZYTld7vCkc?= =?us-ascii?Q?5wCDtii+fcQzuXh72Iho9Qmxyhvks3DDtYJCB/CNRJJwm3eabZ7p3+g4g7Fu?= =?us-ascii?Q?VyKHW+hqo8pkKHa2NoC651WCdvYS79+icObTFJLAttypavthOMVeopxXw6BE?= =?us-ascii?Q?i3a5uWcGQD4K0JBdJCZWwCfDpbVOO7IsQ1355zfoc1kspcWnT6giq2jpeSwR?= =?us-ascii?Q?X0uO4DPue8u5NO5IDhSPdDjxKxCJ8bWnVbbAa63cj5hletC5YYmL7jlOplpB?= =?us-ascii?Q?Z/lZdPmDR4GW0tchytSWbm7DLHpREKSnCeUplrr5cVODC9XtuShuyePg7aQ0?= =?us-ascii?Q?z5Tiy3MvKa93TFsD2A1H5xQY17atX43Z4eLXD51n6hNx492wogOc9eI7iPjQ?= =?us-ascii?Q?MTOQgrEiWAzDfTV//DIP7PcKJK8AuzSqlmVnNNU5vq9X0bngaD9/ZFc4ZhNV?= =?us-ascii?Q?HJdAxtTYsfAI1szfDizVGb0KD4XI7hLs9KGk/vJsNJVnxWMaE0FQqw56pBKe?= =?us-ascii?Q?zFW8D+MxY=3D?= X-Microsoft-Exchange-Diagnostics: 1;BN1PR03MB121;5:EY4SCs0svX1HdleN96GMxdkXE3GMzWaEzeo7zSNW5du+oSA2lYk+IllApmxpdDlnqFzo6677+qqSzH1m8UO/VjE0jN7bhR6U3LU34cZbrxeVYQSFagoyT5KC9KN4zj/qMq2EVmyDWqfpye6vr3xRhA==;24:G+jM6JGr5eTp2F2vsJXE7n0jOcKkWQKWlxGHEdWwIqLcEmDopnlbyLDROPVIA3kPiVVsclqhJMboqs5TSNtY1jl6fhagfmuzSS6QcG732Ps=;20:q9BkTZAUXgryrzMVMW22WQpUB6f/Ay/c8doDQdcGVr5YjG2SkEK97Se88cEZSVcae86T+h9ZumwDs6P/KenYlYe2BIRpPCPFeuU0IaMxwljG8l4LkLfNXn6hmYqzBkI0sen6Yrtp9UOWoOATzbxHjFOEjyIKvMrCFrmrO121J/w= X-OriginatorOrg: opensource.altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jul 2015 18:29:47.0204 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a;Ip=[66.35.236.236];Helo=[sj-itexedge04.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN1PR03MB121 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1942 Lines: 63 On Fri, 17 Jul 2015, Randy Dunlap wrote: > On 07/17/15 08:51, atull@opensource.altera.com wrote: > > From: Alan Tull > > > > --- > > drivers/staging/Kconfig | 2 + > > drivers/staging/Makefile | 1 + > > drivers/staging/fpga/Kconfig | 14 ++ > > drivers/staging/fpga/Makefile | 8 + > > drivers/staging/fpga/fpga-mgr.c | 373 +++++++++++++++++++++++++++++++++++++++ > > include/linux/fpga/fpga-mgr.h | 127 +++++++++++++ > > 6 files changed, 525 insertions(+) > > create mode 100644 drivers/staging/fpga/Kconfig > > create mode 100644 drivers/staging/fpga/Makefile > > create mode 100644 drivers/staging/fpga/fpga-mgr.c > > create mode 100644 include/linux/fpga/fpga-mgr.h > > > diff --git a/drivers/staging/fpga/Kconfig b/drivers/staging/fpga/Kconfig > > new file mode 100644 > > index 0000000..8254ca0 > > --- /dev/null > > +++ b/drivers/staging/fpga/Kconfig > > @@ -0,0 +1,14 @@ > > +# > > +# FPGA framework configuration > > +# > > + > > +menu "FPGA Configuration Support" > > + > > +config FPGA > > + bool "FPGA Configuration Framework" > > + help > > + Say Y here if you want support for configuring FPGAs from the > > + kernel. The FPGA framework adds a FPGA manager class and FPGA > > + manager drivers. > > + > > +endmenu > > Is there some good reason why this is 'bool' instead of 'tristate'? > I.e., why can't it be built as a loadable module? Hi Randy, The simple fpga bus probe function will need probe deferral added for it to work with that if it gets probed before the fpga manager is loaded. But I think it needed that anyway. I'll work on it. Thanks, Alan > > Thanks. > > -- > ~Randy > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/