Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753103AbbGQSrf (ORCPT ); Fri, 17 Jul 2015 14:47:35 -0400 Received: from mail-yk0-f177.google.com ([209.85.160.177]:34370 "EHLO mail-yk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753008AbbGQSrc (ORCPT ); Fri, 17 Jul 2015 14:47:32 -0400 MIME-Version: 1.0 X-Originating-IP: [37.11.0.18] In-Reply-To: <20150717164927.GA21691@localhost> References: <1431618016-2087-1-git-send-email-javier.martinez@collabora.co.uk> <1431618016-2087-3-git-send-email-javier.martinez@collabora.co.uk> <55A6FE07.7000604@samsung.com> <20150717164927.GA21691@localhost> Date: Fri, 17 Jul 2015 20:47:31 +0200 Message-ID: Subject: Re: [PATCH 2/9] ARM: multi_v7_defconfig: Enable max77802 regulator, rtc and clock drivers From: Javier Martinez Canillas To: Olof Johansson Cc: Krzysztof Kozlowski , arm@kernel.org, Arnd Bergmann , Kevin Hilman , Doug Anderson , Kukjin Kim , "linux-samsung-soc@vger.kernel.org" , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2669 Lines: 72 Hello Olof, On Fri, Jul 17, 2015 at 6:49 PM, Olof Johansson wrote: > On Thu, Jul 16, 2015 at 09:42:47AM +0900, Krzysztof Kozlowski wrote: >> On 16.07.2015 00:38, Javier Martinez Canillas wrote: >> > Hello, >> > >> > On Thu, May 14, 2015 at 5:40 PM, Javier Martinez Canillas >> > wrote: >> >> The Maxim max77802 Power Management IC is used on many Exynos machines. >> >> Besides a bunch of regulators, this chip has a Real-Time-Clock (RTC) >> >> and 2-channel 32kHz clock outputs. >> >> >> >> Enable the kernel config options to have the drivers for these devices >> >> built as a module. >> >> >> >> Signed-off-by: Javier Martinez Canillas >> >> --- >> >> arch/arm/configs/multi_v7_defconfig | 3 +++ >> >> 1 file changed, 3 insertions(+) >> >> >> >> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig >> >> index 2349584b6e08..080120fe5580 100644 >> >> --- a/arch/arm/configs/multi_v7_defconfig >> >> +++ b/arch/arm/configs/multi_v7_defconfig >> >> @@ -373,6 +373,7 @@ CONFIG_POWER_RESET_SYSCON=y >> >> CONFIG_REGULATOR_MAX8907=y >> >> CONFIG_REGULATOR_MAX8973=y >> >> CONFIG_REGULATOR_MAX77686=y >> >> +CONFIG_REGULATOR_MAX77802=m >> > >> > I noticed that the version that landed in 4.2-rc1 as commit >> > f3caa529c6f5 ("ARM: multi_v7_defconfig: Enable max77802 regulator, rtc >> > and clock drivers") doesn't include this symbol. I guess it was caused >> > by a wrong resolved conflict? I'll post a patch to enable the >> > regulator again. >> >> As you can see in mentioned mainline commit Kukjin removed it manually: >> [kgene@kernel.org: removing useless REGULATOR_MAX77802 config] >> >> I wonder why? > > Seems odd. exynos_defconfig still enables it. > Yeah since it is needed for at least the Exynos5420 Peach Pit and Exynos5800 Peach Pi Chromebooks that use this PMIC. > Javier or Krzysztof, please send an incremental fix to enable and I'll pick > it up as a fix. > I already posted an incremental patch [0] and Krzysztof is pushing it through Kukjin for 4.3 [1]. I guess that's OK and there is no need to add it as a fix for the 4.2 -rc cycle since this is not really a regression. I mean, the max77802 regulator driver was never enabled for multi_v7_defconfig before. > > -Olof [0]: https://lkml.org/lkml/2015/7/16/60 [1]: https://lkml.org/lkml/2015/7/17/93 Best regards, Javier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/