Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755599AbbGQTCS (ORCPT ); Fri, 17 Jul 2015 15:02:18 -0400 Received: from mail-lb0-f176.google.com ([209.85.217.176]:34946 "EHLO mail-lb0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752664AbbGQTCQ (ORCPT ); Fri, 17 Jul 2015 15:02:16 -0400 MIME-Version: 1.0 In-Reply-To: <1437047167-5634-5-git-send-email-brgerst@gmail.com> References: <1437047167-5634-1-git-send-email-brgerst@gmail.com> <1437047167-5634-5-git-send-email-brgerst@gmail.com> From: Andy Lutomirski Date: Fri, 17 Jul 2015 12:01:55 -0700 Message-ID: Subject: Re: [PATCH 4/7] x86/vm86: Move vm86 fields out of thread_struct To: Brian Gerst Cc: X86 ML , "linux-kernel@vger.kernel.org" , Ingo Molnar , "H. Peter Anvin" , Denys Vlasenko , Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 764 Lines: 24 On Thu, Jul 16, 2015 at 4:46 AM, Brian Gerst wrote: > Allocate a separate structure for the vm86 fields. > > --- a/arch/x86/mm/fault.c > +++ b/arch/x86/mm/fault.c > @@ -315,12 +315,12 @@ check_v8086_mode(struct pt_regs *regs, unsigned long address, > { > unsigned long bit; > > - if (!v8086_mode(regs)) > + if (!v8086_mode(regs) || !tsk->thread.vm86) > return; > What's this for? Shouldn't that "if (!v8086_mode(regs) || WARN_ON(!tsk->thread.vm86))"? --Andy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/