Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752840AbbGQTqo (ORCPT ); Fri, 17 Jul 2015 15:46:44 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:54669 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751901AbbGQTqn (ORCPT ); Fri, 17 Jul 2015 15:46:43 -0400 Date: Fri, 17 Jul 2015 21:46:13 +0200 From: Peter Zijlstra To: Josh Poimboeuf Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Michal Marek , Andy Lutomirski , Borislav Petkov , Linus Torvalds , Andi Kleen , Pedro Alves , x86@kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 12/21] sched: Add __schedule() to stackvalidate whitelist Message-ID: <20150717194613.GQ19282@twins.programming.kicks-ass.net> References: <6decd725802447eb2ba0c914c3d70610a606c2b7.1437150175.git.jpoimboe@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6decd725802447eb2ba0c914c3d70610a606c2b7.1437150175.git.jpoimboe@redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1074 Lines: 19 On Fri, Jul 17, 2015 at 11:47:28AM -0500, Josh Poimboeuf wrote: > stackvalidate reports the following warnings for __schedule(): > > stackvalidate: kernel/sched/core.o: __schedule()+0x3e7: duplicate frame pointer save > stackvalidate: kernel/sched/core.o: __schedule()+0x424: sibling call from callable instruction with changed frame pointer > stackvalidate: kernel/sched/core.o: __schedule()+0x431: call without frame pointer save/setup > stackvalidate: kernel/sched/core.o: __schedule()+0x8b8: frame pointer state mismatch > stackvalidate: kernel/sched/core.o: __schedule()+0x447: frame pointer state mismatch > > __schedule() is obviously a special case which is allowed to do unusual > things with the frame pointer. Yes, but is the code actually correct? We can't dismiss the warnings just on that basis alone. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/