Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753817AbbGQUTE (ORCPT ); Fri, 17 Jul 2015 16:19:04 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:38386 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750863AbbGQUTC (ORCPT ); Fri, 17 Jul 2015 16:19:02 -0400 Date: Fri, 17 Jul 2015 13:19:00 -0700 From: Andrew Morton To: Tejun Heo Cc: Johannes Weiner , Michal Hocko , Vladimir Davydov , linux-mm@kvack.org, LKML Subject: Re: [PATCH 1/5] memcg: export struct mem_cgroup Message-Id: <20150717131900.5b0b5d91597d207c474be7a5@linux-foundation.org> In-Reply-To: <20150717151827.GB15934@mtj.duckdns.org> References: <1436958885-18754-1-git-send-email-mhocko@kernel.org> <1436958885-18754-2-git-send-email-mhocko@kernel.org> <20150715135711.1778a8c08f2ea9560a7c1f6f@linux-foundation.org> <20150716071948.GC3077@dhcp22.suse.cz> <20150716143433.e43554a19b1c89a8524020cb@linux-foundation.org> <20150716225639.GA11131@cmpxchg.org> <20150716160358.de3404c44ba29dc132032bbc@linux-foundation.org> <20150717122819.GA14895@cmpxchg.org> <20150717151827.GB15934@mtj.duckdns.org> X-Mailer: Sylpheed 3.4.1 (GTK+ 2.24.23; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 21 On Fri, 17 Jul 2015 11:18:27 -0400 Tejun Heo wrote: > Maybe there are details to be improved but I think > it's about time mem_cgroup definition gets published. grumble. enum mem_cgroup_events_target can remain private to memcontrol.c. It's only used by mem_cgroup_event_ratelimit() and that function is static. Why were cg_proto_flags and cg_proto moved from include/net/sock.h? struct mem_cgroup_stat_cpu can remain private to memcontrol.c. Forward declare the struct in memcontrol.h. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/